On Thu, Feb 07, 2019 at 01:41:54PM +0100, Andreas Tille wrote:
> On Thu, Feb 07, 2019 at 12:03:46PM +0100, Fabian Klötzl wrote:
> > I had a look and could trace the failure to two issues. 1) The test should
> > run sequentially; can be fixed via a simple override. 2) The previous commit
> > (ARCH32) doesn't work as expected [1]. Building on AMD64 will still have the
> > -DARCH32 flags. This then leads to a different hash function being used and
> > the tests failing. I tried to fix the conditional in the makefile but cannot
> > figure out what is wrong with it in the first place. Also it should
> > deactivate unit tests on 32bit while at it. Could you take another look at
> > the conditional?
>
> Works. Just uploaded. Thanks a lot for your contribution, Andreas.
Unfortunately the -DARCH32 flag (which is set according to the build log[1])
does
not help on i386 architecture:
./mash info -d test/reads.msh > test/reads.json
diff test/genomes.json test/ref/genomes.json
7c7
< "hashType" : "MurmurHash3_x86_32",
---
> "hashType" : "MurmurHash3_x64_128",
There are also build issues of libmurmurhash on some architectures[2]
Any idea what to do next?
Kind regards
Andreas.
[1]
https://buildd.debian.org/status/fetch.php?pkg=mash&arch=i386&ver=2.1%2Bdfsg-1&stamp=1549547123&raw=0
[2] https://buildd.debian.org/status/package.php?p=libmurmurhash&suite=sid
--
http://fam-tille.de
