Steve Langasek <[EMAIL PROTECTED]> writes:

Hi Steve,

I've been busy but I ahve now prepared new verison of the package.
If you find the time to check it, that would be welcomed.

>> > Severity: grave, because amd64 is a release architecture.
>
>> > Jari, if you have packages for 1.1 available, I might be able to
>> > sponsor an upload of them for you.
>
>>   http://cante.net/~jaalto/tmp/debian/jwm
>
> Some changes:
>
> - The package is a native package (no .orig.tar.gz).  Please change it to
>   non-native.

I used options:

  svn-buildpackage -uc -us -rfakeroot

Let me know how to fix this issue if this is not correct method.

> - You are closing bug #327013 in the changelog, but you say this is *not*
>   the version which fixes it; please don't do this.  Close the bug using the
>   BTS mail interface instead.

Thanks. Done.

> - You have duplicate build-dependencies on libx11-dev.  You may also
>   (looking at the diff) be missing a build-dependency on libpng-dev?

Added. and libxinerama-dev and other too.

> - The trunk/ directory contains a complete second copy of the sources, which
>   almost certainly shouldn't be there; I'm assuming this isn't present in
>   the upstream tarball.

I've swithed to svn-buildpackage which presumably handles this
correctly.

> - The package does not build from source because debian/rules calls "make",
>   not "make all", and the first (i.e., default) rule in the Makefile is
>   *not* "all" -- it's "dput-local".

Fixed. I forgot that the first target is "the default".

> If you address these issues, I should be able to upload for you.  I was able
> to reproduce the original bug on alpha with 0.23-3, and the bug does not
> occur with jwm 1.1-1.
>
> Also, I see that you're build-depending on libxt-dev; it should be trivial
> to remove the need for libxt-dev just by re-running autoconf on the source
> package before building, so please consider this alternative.

autoconf rerun. You can get new build at

  http://cante.net/~jaalto/tmp/debian/jwm

Jari



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to