On Sun, Feb 05, 2006 at 11:10:55PM +0200, Jari Aalto wrote:
> Steve Langasek <[EMAIL PROTECTED]> writes:

> > On Sat, Feb 04, 2006 at 09:00:06PM +0200, Jari Aalto wrote:

> >> >>   http://cante.net/~jaalto/tmp/debian/jwm

> >>   svn-buildpackage -uc -us -rfakeroot

> > Yes, that appears to have done the correct thing for the most part; the
> > package is correctly non-native, and the trunk directory is gone -- the only
> > problem I see now is that your .orig.tar.gz contains .svn directories which
> > it should not; since
> > "svn+ssh://[EMAIL PROTECTED]/home/svn/deb/pkg/jwm/trunk" is not a svn uri
> > that's valid for anyone else, the svn metadata doesn't belong in the
> > orig.tar.gz, and having it there doubles the size of the tarball.  Please
> > rebuild your tarball with --exclude .svn.  It's also common practice to
> > exclude the debian/ directory from the upstream tarball, even when it's
> > present in the same source repository, since (among other reasons) it's not
> > possible to delete a file from under debian/ using the .diff.gz...

> I'll keep these in mind in the future.

> > Everything else looks good, so if you get this taken care of I can
> > upload it with no problems.

> Thank you for your time and good suggestions. I think I made some
> fundamental mistake with 1.1 + svn-buildpackage and that's why the
> .svn dirs are there. 

> I've upgrade to 1.3 as well, so you can get the new *.deb files from

>    http://cante.net/~jaalto/tmp/debian/jwm

Ok, was able to review this finally, and it looks good.  Will be uploaded
shortly.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to