On Sa, 2015-10-31 at 20:39 +0000, Olly Betts wrote: > On Sat, Oct 31, 2015 at 02:16:28PM +0100, Moritz Muehlenhoff wrote: > > On Thu, May 21, 2015 at 02:31:29PM +0300, Sebastian Dröge wrote: > > > Hi Olly, > > > > > > On Do, 2015-05-21 at 01:24 +0100, Olly Betts wrote: > > > > > > > But there's an upstream ticket about switching to gstreamer 1.0 > > > > with a > > > > recently added patch. I'd appreciate a quick review from > > > > someone who > > > > has more idea about gstreamer's API than I do if you have a few > > > > minutes > > > > (it's not a huge patch): > > > > > > > > http://trac.wxwidgets.org/attachment/ticket/14976/gst1.0.patch > > > > > > > > I can tell the configure part needs improving, at least to make > > > > it > > > > upstream-able, which makes me wonder about its general quality. > > > > > > wxGStreamerMediaBackend::QueryVideoSizeFromPad() probably leaks > > > the caps > > > now, you need to unref() them after usage. > > > > > > !gst_structure_has_name (gst_message_get_structure(message), > > > "prepare-window-handle")) > > > should be using > > > gst_is_video_overlay_prepare_window_handle_message() > > > > > > Otherwise seems ok if that is really enough to make things work. > > > Not > > > sure if more changes are needed elsewhere. > > > > what's the status? wxwidgets is now one of the two remaining > > packages > > blocking the removal of gstreamer 0.10 from stretch. > > Status is stalled, essentially. > > I gather from what slomo said that the current patch isn't suitable > for applying.
The first remark is a minor memory leak, the second is just cleanup (and usage of the correct API) but at this time has no functional difference (but might in the future). The leak you can fix by adding a simple gst_caps_unref() for the caps in that function. Does the patch work otherwise? If so, just get it in after adding that one line mentioned above :)
signature.asc
Description: This is a digitally signed message part
