On Sat, Oct 31, 2015 at 02:16:28PM +0100, Moritz Muehlenhoff wrote:
> On Thu, May 21, 2015 at 02:31:29PM +0300, Sebastian Dröge wrote:
> > Hi Olly,
> >
> > On Do, 2015-05-21 at 01:24 +0100, Olly Betts wrote:
> >
> > > But there's an upstream ticket about switching to gstreamer 1.0 with a
> > > recently added patch. I'd appreciate a quick review from someone who
> > > has more idea about gstreamer's API than I do if you have a few minutes
> > > (it's not a huge patch):
> > >
> > > http://trac.wxwidgets.org/attachment/ticket/14976/gst1.0.patch
> > >
> > > I can tell the configure part needs improving, at least to make it
> > > upstream-able, which makes me wonder about its general quality.
> >
> > wxGStreamerMediaBackend::QueryVideoSizeFromPad() probably leaks the caps
> > now, you need to unref() them after usage.
> >
> > !gst_structure_has_name (gst_message_get_structure(message),
> > "prepare-window-handle"))
> > should be using
> > gst_is_video_overlay_prepare_window_handle_message()
> >
> > Otherwise seems ok if that is really enough to make things work. Not
> > sure if more changes are needed elsewhere.
>
> what's the status? wxwidgets is now one of the two remaining packages
> blocking the removal of gstreamer 0.10 from stretch.
Status is stalled, essentially.
I gather from what slomo said that the current patch isn't suitable
for applying. But I don't know anything about the old or new gstreamer
APIs, and don't have the spare time to learn them, so the chances of me
successfully fixing up the patch in response to slomo's feedback are
pretty much non-existent.
There's been no response from upstream or the original patch author to
slomo's feedback on the patch so far. I prodded them last week about
this, which hasn't had a response yet either.
My impression (from responses and lack of responses to previous bug
reports about the wxmedia stuff) is that it's not a feature which the
active upstream developers care much about, so I suspect any fixes will
need to come from outside.
Despite quite a lot of noise about enabling it, it only actually seems
to be used by whyteboard currently (at least if I can work "dak rm"),
and support for playing video there hardly seems an essential feature.
So a rather brutal way out might be to disable support again, and if
that upsets anyone, then ... well, improved patches welcome.
Cheers,
Olly
