Your message dated Mon, 01 Dec 2014 23:49:12 +0000 with message-id <e1xvaio-0007yy...@franck.debian.org> and subject line Bug#771470: fixed in ltsp 5.5.4-2 has caused the Debian Bug report #771470, regarding ltsp-client-core: Kernel version sorting may result in booting obsolete kernel to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 771470: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771470 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: ltsp-client-core Version: 5.5.4-1 Severity: serious Tags: patch When upgrading an LTSP environment from Wheezy, LTSP's kernel sorting rules generate a pxelinux.cfg/ltsp file that defaults to the -486 Wheezy kernel variant, instead of the -586 variant present in Jessie. This results in clients booting an old kernel and quite possibly missing security updates. Additionally, if the configures IFCPU64=true in /etc/ltsp/update-kernels.conf which should set up pxelinux entries to boot the appropriate kernel based 32-bit, PAE or 64-bit machines, the rules always pick the lowest common denominator for all the kernels (and adding insult to injury, the lowest possible version). I plan to upload a fixed version shortly... The following patches were committed upstream, and should resolve this issue: From: Alkis Georgopoulos <alk...@gmail.com> Date: Sat, 29 Nov 2014 17:51:04 +0200 Subject: [PATCH 15/17] Correctly sort kernel FLAVOR in increasing order and VERSION in decreasing. --- client/Debian/etc/ltsp/update-kernels.conf | 2 +- client/Debian/share/ltsp/cleanup.d/50-vmlinuz | 2 +- client/Ubuntu/etc/ltsp/update-kernels.conf | 2 +- client/share/ltsp/update-kernels | 4 ++-- server/ltsp-update-kernels | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/Debian/etc/ltsp/update-kernels.conf b/client/Debian/etc/ltsp/update-kernels.conf index b22e0a6..97131b5 100644 --- a/client/Debian/etc/ltsp/update-kernels.conf +++ b/client/Debian/etc/ltsp/update-kernels.conf @@ -28,7 +28,7 @@ CMDLINE_NBD="root=/dev/nbd0" CMDLINE_AOE="root=/dev/etherd/e0.0" # A sed expression that matches all kernels and returns $FILE $NAME $VERSION $FLAVOR -# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3 +# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV KERNEL_NAMES='s/\(vmlinu[xz]-\)\([^-]*-[^-]*-\)\(.*\)/& \1 \2 \3/p' # A sed expression that maps from a kernel name to an initrd name diff --git a/client/Debian/share/ltsp/cleanup.d/50-vmlinuz b/client/Debian/share/ltsp/cleanup.d/50-vmlinuz index 3a88d30..82fb818 100644 --- a/client/Debian/share/ltsp/cleanup.d/50-vmlinuz +++ b/client/Debian/share/ltsp/cleanup.d/50-vmlinuz @@ -14,7 +14,7 @@ INITRD_NAME=${INITRD_NAME:-'s/vmlinu[xz]/initrd.img/p'} read file name version flavor <<EOF $(find "/boot/" -mindepth 1 -maxdepth 1 -type f -printf "%f\n" | - sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3) + sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV) EOF initrd=$(echo "$file" | sed -n "$INITRD_NAME") diff --git a/client/Ubuntu/etc/ltsp/update-kernels.conf b/client/Ubuntu/etc/ltsp/update-kernels.conf index 059cd68..6e3d2f8 100644 --- a/client/Ubuntu/etc/ltsp/update-kernels.conf +++ b/client/Ubuntu/etc/ltsp/update-kernels.conf @@ -28,7 +28,7 @@ CMDLINE_NBD="root=/dev/nbd0" CMDLINE_AOE="root=/dev/etherd/e0.0" # A sed expression that matches all kernels and returns $FILE $NAME $VERSION $FLAVOR -# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3 +# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV KERNEL_NAMES='s/\(vmlinu[xz]-\)\([^-]*-[^-]*-\)\(.*\)/& \1 \2 \3/p' # A sed expression that maps from a kernel name to an initrd name diff --git a/client/share/ltsp/update-kernels b/client/share/ltsp/update-kernels index 61e7eae..96310fb 100755 --- a/client/share/ltsp/update-kernels +++ b/client/share/ltsp/update-kernels @@ -67,7 +67,7 @@ kernel_split() { ;; esac done - done | sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3 + done | sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV eval "$orig_flags" } @@ -102,7 +102,7 @@ cmdline_method_default=$(eval echo '$CMDLINE_'$boot_method_default) BOOTPROMPT_OPTS="$CMDLINE_LINUX_DEFAULTS $cmdline_method_default" # A sed expression that matches all kernels and returns $FILE $NAME $VERSION $FLAVOR -# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3 +# Example: ls /boot | sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV KERNEL_NAMES=${KERNEL_NAMES:-'s/\(vmlinu[xz]-\)\([^-]*-[^-]*-\)\(.*\)/& \1 \2 \3/p'} if [ -f /usr/lib/yaboot/yaboot ]; then diff --git a/server/ltsp-update-kernels b/server/ltsp-update-kernels index 4a71b2b..3e08149 100755 --- a/server/ltsp-update-kernels +++ b/server/ltsp-update-kernels @@ -151,7 +151,7 @@ link_kernel_flavors() { last_flavor= find "$tftpname" -mindepth 1 -maxdepth 1 -type f -printf "%f\n" \ - | sed -n "$KERNEL_NAMES" | sort -V -k 4,4 | sort -r -k 3,3 \ + | sed -n "$KERNEL_NAMES" | sort -k 4,4V -k 3,3rV \ | while read file name version flavor; do if [ "$flavor" != "$last_flavor" ]; then initrd=$(echo "$file" | sed -n "$INITRD_NAME") -- 2.1.3 From: Vagrant Cascadian <vagr...@debian.org> Date: Sat, 29 Nov 2014 10:57:26 -0800 Subject: [PATCH 16/17] update-kernels: Fix issues with kernel version variant sorting by first looping on the preferred variants, and using the keyword "ALL" instead of "*" to avoid shell globbing issues. --- client/share/ltsp/update-kernels | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/client/share/ltsp/update-kernels b/client/share/ltsp/update-kernels index 96310fb..5e079be 100755 --- a/client/share/ltsp/update-kernels +++ b/client/share/ltsp/update-kernels @@ -59,6 +59,9 @@ kernel_split() { set -f for kernel in $(find "/boot/" -type f -name "$KERNEL_PREFIX$KERNEL_SUFFIX" -printf "%f\n"); do # Validate the "arch" + if [ "${LIST_KERNELS}" = "ALL" ]; then + LIST_KERNELS="*" + fi for arch in ${LIST_KERNELS:-*}; do case "$kernel" in $KERNEL_PREFIX$arch$KERNEL_SUFFIX) @@ -73,7 +76,9 @@ kernel_split() { } kernel_versions(){ - kernel_split | awk '{print $3$4}' + for arch in ${LIST_KERNELS:-"ALL"} ; do + LIST_KERNELS="$arch" kernel_split | awk '{print $3$4}' + done } kernel_variants(){ @@ -205,7 +210,7 @@ EOF pxelinux_include_files="$pxelinux_include_files ltsp-$method" # Get the preferred default kernel, preferred 32-bit kernel, or any # kernel. - version=$(LIST_KERNELS="$LIST_KERNELS_DEFAULT $LIST_KERNELS_32 *" kernel_versions | head -n 1) + version=$(LIST_KERNELS="$LIST_KERNELS_DEFAULT $LIST_KERNELS_32 ALL" kernel_versions | head -n 1) cat > $PXECFG/ltsp-$method <<EOF # This file is regenerated when update-kernels runs. # Do not edit, see /etc/ltsp/update-kernels.conf instead. @@ -250,7 +255,7 @@ EOF 32) list_kernels="$LIST_KERNELS_32" ;; esac # only return the newest kernel of appropriate type. - version=$(LIST_KERNELS="$list_kernels *" kernel_versions | head -n 1) + version=$(LIST_KERNELS="$list_kernels ALL" kernel_versions | head -n 1) cat >> $PXECFG/ltsp-ifcpu64-$method <<EOF label ltsp-$method-$type @@ -313,7 +318,7 @@ if [ "$(detect_arch)" = "armhf" ] || [ "$(detect_arch)" = "armel" ]; then if which mkimage >/dev/null; then # Generate a boot script for use with versions of u-boot # supporting bootz. - version=$(LIST_KERNELS="$LIST_KERNELS_DEFAULT $LIST_KERNELS_ARM *" kernel_versions | head -n 1) + version=$(LIST_KERNELS="$LIST_KERNELS_DEFAULT $LIST_KERNELS_ARM ALL" kernel_versions | head -n 1) kernel_file="/ltsp/${CHROOT_NAME}/vmlinuz-${version}" initrd_file="/ltsp/${CHROOT_NAME}/initrd.img-${version}" fdt_dir="/ltsp/${CHROOT_NAME}/dtbs-${version}/" -- 2.1.3 From: Vagrant Cascadian <vagr...@debian.org> Date: Sat, 29 Nov 2014 11:08:02 -0800 Subject: [PATCH 17/17] Debian: update-kernels.conf: Prefer 586 over 486 in for 32 bit systems, as 486 is no longer shipped in Jessie. --- client/Debian/etc/ltsp/update-kernels.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: ltsp/client/Debian/etc/ltsp/update-kernels.conf =================================================================== --- ltsp.orig/client/Debian/etc/ltsp/update-kernels.conf +++ ltsp/client/Debian/etc/ltsp/update-kernels.conf @@ -44,7 +44,7 @@ LIST_KERNELS_64="amd64" # Variants that are supported by PAE capable CPUs LIST_KERNELS_PAE="686-pae 686-bigmem 686" # Variants that are widely supported (i.e. 32-bit CPUs) -LIST_KERNELS_32="486 686" +LIST_KERNELS_32="586 486 686" # Preferred default kernel order #LIST_KERNELS_DEFAULT="486-custom 686-custom" live well, vagrant
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---Source: ltsp Source-Version: 5.5.4-2 We believe that the bug you reported is fixed in the latest version of ltsp, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 771...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Vagrant Cascadian <vagr...@debian.org> (supplier of updated ltsp package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 01 Dec 2014 15:22:01 -0800 Source: ltsp Binary: ltsp-server ltsp-server-standalone ltsp-client-core ltsp-client ltsp-client-builder Architecture: source all Version: 5.5.4-2 Distribution: unstable Urgency: medium Maintainer: LTSP Debian Maintainers <pkg-ltsp-de...@lists.alioth.debian.org> Changed-By: Vagrant Cascadian <vagr...@debian.org> Description: ltsp-client - complete LTSP client environment ltsp-client-builder - build an LTSP environment in the installer target (udeb) ltsp-client-core - basic LTSP client environment ltsp-server - basic LTSP server environment ltsp-server-standalone - complete LTSP server environment Closes: 771470 771728 Changes: ltsp (5.5.4-2) unstable; urgency=medium . * ltsp-update-kernels/update-kernels: Fix kernel version sorting that results in clients booting obsolete kernels (Closes: #771470). . * update-kernels: Suppress mkimage output, as it prevents linux-image packages from being removed successfully (Closes: #771728). . * ltsp-build-client: Remove plugin that needlessly modifies pulseaudio configuration files. . * ltsp-update-kernels: Remove dtb files when corresponding kernel version is no longer present. . * debian/copyright: Remove outdated VCS information. Checksums-Sha1: 4cc1977ad532fdcd385273a34d698be61ca595b0 2285 ltsp_5.5.4-2.dsc 33f630fd423b3d764ec11b46d2cb26baf7497754 76920 ltsp_5.5.4-2.debian.tar.xz 8457fbb1e74131c30e978369b0b3833484d13e55 265926 ltsp-server_5.5.4-2_all.deb 358f6ee428d5b6e3c25ec0d5fa6b6fe4309f6a02 146034 ltsp-server-standalone_5.5.4-2_all.deb 3201b1c37eb2e946b65d7d4dd9ccf1efa4a81df4 11124 ltsp-client-builder_5.5.4-2_all.udeb Checksums-Sha256: 5ad0f843e0fa19fb1f49110f3ca47de56f10ec12b7f4406cabf1d90a6daf8981 2285 ltsp_5.5.4-2.dsc 5ddfa046c2120a789a103f515de93dbbc483a4edd02fd97429255cca662aba56 76920 ltsp_5.5.4-2.debian.tar.xz 053a5956fd2b25b5b37451bdc7091e36202737b178b1120d3ada67ef1c3a5862 265926 ltsp-server_5.5.4-2_all.deb 4baa918f6941b1a940199e08461ede0f0909ec415d88928dfd0042da3f552112 146034 ltsp-server-standalone_5.5.4-2_all.deb 5b2a55edbd4e355270ceeda32ac94c3414b558f6b028b71f5a1b7e2363cf30e1 11124 ltsp-client-builder_5.5.4-2_all.udeb Files: 27627d671721e036a2a2dfa02f0dc4a3 2285 misc extra ltsp_5.5.4-2.dsc 3ac43d4377dbcd06b0fdb2b2b2ba1f01 76920 misc extra ltsp_5.5.4-2.debian.tar.xz 01a8f86ff21ecc854c34db66f044e94d 265926 misc extra ltsp-server_5.5.4-2_all.deb 335658f93eab260b40554ef41dda5f08 146034 misc extra ltsp-server-standalone_5.5.4-2_all.deb 4f99f6e530a1138bd1d607dc6452e045 11124 debian-installer extra ltsp-client-builder_5.5.4-2_all.udeb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUfPoyAAoJELeLgtSBS5G2AocP+QFAkSSnyBe7oph5kRNhdY4Y M8dHaQ830IFBxMR+atse7f05ASiUMDo3HJma4fR0GZHLFs5L/oe/oV9ArIAuDNNi YVrTzfNT+Eze6pQ4WxDPo9AtLp3yyAQNNbXbjRQSyyl4Oe3l6XxBJcqMqSZ1gS9k 409Jp3M1llp9VwVSJ1dRIN+BNcOKV+9137jABLiKxoj/TepuznGjDZ65XMwX5mK2 lajxjDpmRFT+/MIhQEE/V7hwFqY72nJv2qQt/cmOOU+HEtYG56mZZOxGEMuGpSbH 4H1XC+Gy7puv2aHS0hOMjq07XSEYkEQGt3D4ZGZylq0n/ZLzNxjjAG10EcM1Z1zh 4rPO23Fw0GmBHZ9XHAE0S7B6cPG5+k3BAXlT1tJm6dD7P6PLlmOYpmaAiM8wcTeH mVBKFQ4w3/rMLH+6Uio2SaRp8JKe8hZO9os5XxUlVZJRHAcsMpl97xzBSpHVZeFB XR5DYklAEPONSjEIZTbGXISahXh1bENA5ft0szJYqcXnTf+6gWzUl80eBMrJ1kxW SC1CcVeRQMKmKcJoPEZHH7NMEeTMJpPd51q8sVp/fQtq/taA8Ptq6HoRyofDxqFf 0JTxIqel37vyM9VK8U67zld40hu4TsbmEQF49p6HrdMueIsNBxoRmul54RCq5Q7j ba1wCuCjQWU7SCOfp+/J =EIJE -----END PGP SIGNATURE-----
--- End Message ---