On Tue, Nov 25 2014, Daniel Kahn Gillmor <d...@fifthhorseman.net> wrote:
> Thanks for the proposed patch.  I'm not sure how to test it directly,
> but it seems a bit overzealous to me -- it's trying to read from stdin
> even when a logging argument was passed to it.
>
> I suspect this only passes the test suite because the log level is set
> to DEBUG in the test suite; otherwise i'd expect a hang.
>
> I think we need a more finely-tuned patch to get this to work.

Yeah, I realized this not long after I submitted it, but I was traveling
at that point and wasn't in front of my computer.  Sorry about that.

jamie.

Attachment: signature.asc
Description: PGP signature

Reply via email to