On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
> On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
> > On 02/14/2012 01:22 AM, Ben Pfaff wrote:
> > > Would it be possible for you to provide your make.log?
> > 
> > I've attached it to this mail.
> 
> Here's the root of the problem:
>    checking for Linux build directory... 
> /usr/src/linux-headers-3.1.0-1-686-pae
>    checking for Linux source directory... configure: error: cannot find 
> source directory (please use --with-linux-source)
> 
> I see that this was already fixed on master with the following commit:
> 
> ----------------------------------------------------------------------
> >From 715a77b74caf22e38d1f232d1cc45036b9b83e62 Mon Sep 17 00:00:00 2001
> From: Ben Pfaff <b...@nicira.com>
> Date: Tue, 10 Jan 2012 14:22:22 -0800
> Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS 
> kernel sources.
> 
> DKMS packages usually look in /lib/modules for kernel sources, since that
> is the "standard" location, but our packages was looking directly in
> /usr/src.  This fixes the problem.
> 
> Reported-by: Alban Browaeys <pra...@yahoo.com>
> Tested-by: Alban Browaeys <pra...@yahoo.com>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
>  AUTHORS             |    1 +
>  debian/dkms.conf.in |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/AUTHORS b/AUTHORS
> index d413523..87b3ccd 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -60,6 +60,7 @@ provided helpful bug reports or suggestions.
>  Aaron M. Ucko           u...@debian.org
>  Aaron Rosen             aro...@clemson.edu
>  Ahmed Bilal             numan...@gmail.com
> +Alban Browaeys          pra...@yahoo.com
>  Alex Yip                a...@nicira.com
>  Alexey I. Froloff       ra...@altlinux.org
>  Bob Ball                bob.b...@citrix.com
> diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
> index 56c6398..a6dc316 100644
> --- a/debian/dkms.conf.in
> +++ b/debian/dkms.conf.in
> @@ -1,6 +1,6 @@
>  PACKAGE_NAME="openvswitch"
>  PACKAGE_VERSION="__VERSION__"
> -MAKE="./configure --with-linux=/usr/src/linux-headers-`uname -r` ; make -C 
> datapath/linux"
> +MAKE="./configure --with-linux=/lib/modules/`uname -r`/build ; make -C 
> datapath/linux"
>  BUILT_MODULE_NAME[0]=openvswitch_mod
>  BUILT_MODULE_NAME[1]=brcompat_mod
>  BUILT_MODULE_LOCATION[0]=datapath/linux/
> ----------------------------------------------------------------------
> 
> Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
> now cherry-picked it to both branches, so the next Debian upload
> should incorporate the fix.
> 
> I see that we should really be using "&&' instead of ";" in the make
> rule.  I sent out a patch.

Thanks Ben, I plan to make make a fresh upload for this.

> > During the course of upgrading XCP from 1.3 to 1.3.2, I've hit 3 bugs
> > already. I really hope that's going to be it! :)
> 
> I hope so too.  I hope that the others have been adequately addressed;
> let me know if not.
> 



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to