Le Monday 14 February 2011 21:10:45, vous avez écrit : > On Mon, 14 Feb 2011 17:59:40 +0100, Didier 'OdyX' Raboud wrote: > > I am sorry to reopen this bug but IMHO the fix is not sufficient, see > > below. (private data borkled, huh). > > I think too the fix is not ideal, but it's the quickest I can achieve at > this moment.
Well… We are at the beginning of a developement period; don't aim for the quickiest, but for the best ! > I'm part of the upstream team since a month or so, and I'm working on a > complete rewrite of wicd; so I'd be a bit reluctant to fix "structural" > bugs like this, which would involve some radical change :-) Nice. > However, I'll give it a better try. Cool. > Much of the diff you attached is caused by #568326, I'm sorry. No problem, as long as there is a bug and you are willing to get it fixed before Wheezy's freeze. > The only relevant change is, IMHO: > > -bssid = B4:14:89:D0:31:E3 > > +bssid = B4:14:89:83:F9:B3 > > Why is this happening? Multiple APs with same ESSID? I happen to connect my laptop on my university's WiFi, which has ~600 APs which all provide 3 ESSIDs… > Other than that, I see nothing "unsuitable" for /etc/. Consider this > snippet of > > a newly-found network: > > +[B4:14:89:83:F9:B0] > > +afterscript = None > > +bssid = B4:14:89:83:F9:B0 > > +encryption = True > > +has_profile = False > > +encryption_method = WPA2 > > +essid = epfl > > +postdisconnectscript = None > > +beforescript = None > > +hidden = False > > +predisconnectscript = None > > +channel = 1 > > +mode = Master > > Those are reasonable things to be kept under /etc/, I'd say. I disagree. If it is not something I (as user with "root" rights) have manually entered, it's not suitable. As told above, if I happen to walk around with my WiFi on, I will encounter 100's of APs, which will all land in /etc/ while I haven't configured anything to connect to them. > Maybe "channel" can change, but it doesn't change that often, and it's needed > for connection, so I'd keep it too. > > Here's my proposal: let's drop all the networks with "has_profile = False" > (and let's drop "has_profile" too altogether). Sounds ok? Honestly, I really think that /etc/ should be kept for "root user" hand configuration. All the network configurations I hand to wicd trough non-root GUIs have (IMHO) nothing to do in /etc/ but can perfectly live in /var/lib/wicd/${USER}/configs/${ESSID} . As a personal "crash test", I consider one should be able to run Debian with /etc mounted readonly (I know it will fail due to /etc/resolv.conf, etc, but those are bugs too IMHO). Furthermore, my /etc/wicd/wireless-settings.conf has ~ 4000 lines; it's absolutely not suitable to be edited by hand. Bye, OdyX -- Didier Raboud, proud Debian Developer. CH-1020 Renens o...@debian.org
signature.asc
Description: This is a digitally signed message part.