On Mon, 14 Feb 2011 17:59:40 +0100, Didier 'OdyX' Raboud wrote: > Hi again David,
Hello, > I am sorry to reopen this bug but IMHO the fix is not sufficient, see below. > (private data borkled, huh). I think too the fix is not ideal, but it's the quickest I can achieve at this moment. I'm part of the upstream team since a month or so, and I'm working on a complete rewrite of wicd; so I'd be a bit reluctant to fix "structural" bugs like this, which would involve some radical change :-) However, I'll give it a better try. > I have no problem with wicd keeping the data I give it, but wicd stores much > more than this (bssid's I see, etc), which has nothing to do in /etc/. > > In particular, this block: > > +[B4:14:89:83:F9:B0] > +afterscript = None > +bssid = B4:14:89:83:F9:B0 > +encryption = True > +has_profile = False > ^^^^^ => Hence why keeping that in the "configuration file" ? > +encryption_method = WPA2 > +essid = epfl > +postdisconnectscript = None > +beforescript = None > +hidden = False > +predisconnectscript = None > +channel = 1 > +mode = Master > > I'd be in favour to push all of this in /var/run… For the has_profile=False it perfectly makes sense. Much of the diff you attached is caused by #568326, I'm sorry. The only relevant change is, IMHO: > -bssid = B4:14:89:D0:31:E3 > +bssid = B4:14:89:83:F9:B3 Why is this happening? Multiple APs with same ESSID? Other than that, I see nothing "unsuitable" for /etc/. Consider this snippet of a newly-found network: > +[B4:14:89:83:F9:B0] > +afterscript = None > +bssid = B4:14:89:83:F9:B0 > +encryption = True > +has_profile = False > +encryption_method = WPA2 > +essid = epfl > +postdisconnectscript = None > +beforescript = None > +hidden = False > +predisconnectscript = None > +channel = 1 > +mode = Master Those are reasonable things to be kept under /etc/, I'd say. Maybe "channel" can change, but it doesn't change that often, and it's needed for connection, so I'd keep it too. Here's my proposal: let's drop all the networks with "has_profile = False" (and let's drop "has_profile" too altogether). Sounds ok? Have a nice evening :) David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
signature.asc
Description: PGP signature
