Hi Paul, On Tuesday 23 February 2010, Paul Martin wrote: > Could you try the following patch?
it fixes the problem with this particular config but I don't really like it. It does not change the fact that the config parsing is extremely fragile. If a postrotate script contains an unbalanced number of braces, the problem may reappear. I guess this could happen due to a typo. Possible improvements would be - do the globbing after the whole config has been parsed - if the globbing fails, still run the normal parsing but ignore the result for this config block somehow; for example just remember the globbing error and call removeLogInfo() when the next block is found - require that braces in the postrotate script are escaped in some way (ugly) - if parsing of a file fails, go to the next file immediately (ugly in a different way) - if parsing fails, still try to parse the postrotate/endscript pairs when skipping to the next config Of course, your patch is much better than no patch and makes it much less likely to trigger the problem. But if someone happens to hit the problem anyway, he will have a hard time at finding the reason. In any case, thanks for the very quick response. Cheers, Stefan -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
