Hello all, Stefano Zacchiroli [2010-02-19 18:59 +0100]: > On Tue, Feb 09, 2010 at 10:08:50PM +1100, Ben Finney wrote: > > The attached patch addresses this bug, by declaring the ‘/usr/bin/’ > > directory and installing the programs into the correct location. > > Actually, I'm not sure the patch is the right one. My doubts come from > the fact that postgresql binaries are usually installed under > /usr/lib/postgresql/*/bin/ and then have symlinks under /usr/bin/ which > pass through /usr/share/postgresql-common/pg_wrapper . Are you sure that > pg_prove and pg_tagpen should not have the same fate? Can please the > maintainer comment on that?
I'm a bit confused by pgtap on first sight. It builds against a particular server version (8.4), but does not itself have a versioned package name, and only links/depends on libpq5, no server. * Is pgtap client side only, in other words, does it work with several server versions? In that case, binaries should go to /usr/bin, as Peter and Ben suggested. * If this is a server-side extension, i. e. is linked against a particular server version and won't work with any other, then the binary should have a versioned name, and we need to manage the binaries through pg_wrapper. Please see /usr/share/doc/postgresql-common/architecture.html for some more details about how this is designed. Thanks, and have a good weekend, Martin P.S. Just don't let you confuse with "Use appropriate ‘debian/dirs’ file for single-package source". Using an explicit package name, such as debian/pgtap.dirs is just fine, and causes less confusion if you ever add a second binary package. -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
