On Tue, Jul 08, 2008 at 03:38:59PM +0200, Tomá? Janou?ek wrote: > Hello, > > On Tue, Jul 08, 2008 at 03:30:28PM +0200, Agustin Martin wrote: > > tag 489839 patch > > thanks > > Just adding: > Pls note that that is not the only place in the file with such construct.
Thanks for noticing, The only other place I see is in line 248 in the modified script, 246 in the original one. [ -x /sbin/restorecon ] && /sbin/restorecon -R /dev and there is a rm -rf just after that, so I expect it to not cause problems. However much better if an explicit "if" construct is used here for consistency. On the other hand, [ test foo ] || do_something is safe -- Agustin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
