tag 489839 patch
thanks

On Tue, Jul 08, 2008 at 03:09:03PM +0200, Agustin Martin wrote:
> Attached patch seems to fix the problem here, in a non initrd system
> 
> IIRC, these "[test ] .." constructs should only be used with "||", they
> can have some side effects with "&&".
> 
> -- 
> Agustin

> --- /etc/init.d/udev.orig     2008-07-08 14:57:26.000000000 +0200
> +++ /etc/init.d/udev  2008-07-08 14:57:50.000000000 +0200
> @@ -31,7 +31,9 @@
>    fi
>  
>    # relabel the new tmpfs accordingly
> -  [ -x /sbin/restorecon ] && /sbin/restorecon /dev
> +  if [ -x /sbin/restorecon ]; then
> +    /sbin/restorecon /dev
> +  fi
>  }
>  
>  create_dev_makedev() {

The reference where a bugreport about that was filed against one of my
packages,

http://bugs.debian.org/326257
[postinst fails because of "[...] && ..." construct]

In short, the construct " [ test foo ] && bar" fails, i.e., returns a
non-zero status code, if "foo" fails, and this is the last value got by the
function. Since you use set -e, this makes the shell terminate the entire
script. 

As original submitter points out, adding 'echo -n ""' as the last line in
mount_tmpfs seems to make the function return normally (returns the result
of the echo)

-- 
Agustin



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to