Package: lessdisks
Severity: serious
Justification: makes package unsuitable for release
Version: 0.5.3cvs.20040906-11
Tags: patch

I think it would be a shame if sarge release w/o lessdisks in it. For
one thing, debian-edu needs lessdisks and it would be easier over there
if it were in sarge proper. For another, when I'm not using debian-edu
or full lessdisks, I still find initrd-netboot-tools very useful for
ad-hoc setting up of various arches netboot machines.

Some broken dependencies are keeping the packages out of sarge though:

    kernel-image-netbootable/i386 unsatisfiable Depends: 
kernel-image-2.4-generic | kernel-image-2.6-generic | kernel-image-netboot | 
not+alpha

not+alpha (and not+i386) were provided by type-handling, but that was
deprecated and dropped. There are other ways to accomplish it, and the
attached patch does it by making kernel-image-netbootable arch all and
having separate dependency lines for each supported architecture.

For unsupported/untested architectures, I choose to make it depend on nothing,
although this could be handled better. But I happen to have a lot of
information about using lessdisks on other arches than i386 and alpha, so
see a future bug report with info about nfs rooted systems on hppa, mipsel,
sparc, and ia64!

Anyway, I hope the attached patch can be quickly applied and lessdisks can get
into sarge. I took the liberty of setting the urgency to medium in the
changelog; I think that would be an appropriate urgency if lessdisks were
uploaded with only my patch and no other changes, since the current version
has been excessively well tested by its 65 day long wait in unstable.

-- 
see shy jo
diff -ur --new-file old/lessdisks-0.5.3cvs.20040906/debian/changelog 
lessdisks-0.5.3cvs.20040906/debian/changelog
--- old/lessdisks-0.5.3cvs.20040906/debian/changelog    2005-04-01 
12:59:56.000000000 -1000
+++ lessdisks-0.5.3cvs.20040906/debian/changelog        2005-04-01 
16:02:19.000000000 -1000
@@ -1,3 +1,11 @@
+lessdisks (0.5.3cvs.20040906-12) unstable; urgency=medium
+
+  * Make kernel-image-netbootable arch all so it can have different deps per
+    architectire. The deps for each architecture are listed in a new file, 
+    debian/depends.netbootable.
+
+ -- Joey Hess <[EMAIL PROTECTED]>  Fri,  1 Apr 2005 16:01:10 -1000
+
 lessdisks (0.5.3cvs.20040906-11) unstable; urgency=medium
 
   * Fix (for real this time) the bugs introduced in latest uploads: Now
diff -ur --new-file old/lessdisks-0.5.3cvs.20040906/debian/control 
lessdisks-0.5.3cvs.20040906/debian/control
--- old/lessdisks-0.5.3cvs.20040906/debian/control      2005-04-01 
12:59:57.000000000 -1000
+++ lessdisks-0.5.3cvs.20040906/debian/control  2005-04-01 12:50:21.000000000 
-1000
@@ -125,6 +125,7 @@
 Architecture: all
 Pre-Depends: initrd-tools
 Recommends: udhcpc
+Suggests: kernel-image-netbootable
 Conflicts: lessdisks
 Description: initrd scripts for netboot support
  This package provides helper scripts for initrd-tools to support
@@ -148,9 +149,9 @@
  Website: http://www.lessdisks.net/
 
 Package: kernel-image-netbootable
-Architecture: all
+Architecture: any
 Pre-Depends: initrd-netboot-tools
-Depends: kernel-image-2.4-386 | kernel-image-2.6-386 | kernel-image-netboot | 
not+i386, kernel-image-2.4-generic | kernel-image-2.6-generic | 
kernel-image-netboot | not+alpha
+Depends: ${Depends:netbootable}
 Suggests: mknbi, aboot, mkvmlinuz
 Description: net-bootable kernel for use with diskless systems
  This package attempts to ensure that the system is installable off of
diff -ur --new-file old/lessdisks-0.5.3cvs.20040906/debian/depends.netbootable 
lessdisks-0.5.3cvs.20040906/debian/depends.netbootable
--- old/lessdisks-0.5.3cvs.20040906/debian/depends.netbootable  1969-12-31 
14:00:00.000000000 -1000
+++ lessdisks-0.5.3cvs.20040906/debian/depends.netbootable      2005-04-01 
12:51:14.000000000 -1000
@@ -0,0 +1,2 @@
+i386: kernel-image-2.4-386 | kernel-image-2.6-386 | kernel-image-netboot
+alpha: kernel-image-2.4-generic | kernel-image-2.6-generic | 
kernel-image-netbootable
diff -ur --new-file old/lessdisks-0.5.3cvs.20040906/debian/rules 
lessdisks-0.5.3cvs.20040906/debian/rules
--- old/lessdisks-0.5.3cvs.20040906/debian/rules        2005-04-01 
12:59:57.000000000 -1000
+++ lessdisks-0.5.3cvs.20040906/debian/rules    2005-04-01 16:02:43.000000000 
-1000
@@ -23,6 +23,11 @@
 DEB_INSTALL_EXAMPLES_lessdisks-xterminal = xbase/etc-lessdisks/*
 DEB_INSTALL_EXAMPLES_lessdisks-cloner-terminal = cloner/doc/examples/*
 
+# Substitute in an appropriate depends line for the
+# kernel-image-netbootable Depends.
+DEPENDS_NETBOOTABLE = $(shell grep '^$(DEB_ARCH):' debian/depends.netbootable 
| sed 's/$(DEB_ARCH): //')
+DEB_DH_GENCONTROL_ARGS = -- -VDepends:netbootable="$(DEPENDS_NETBOOTABLE)"
+
 # Make sure these scripts are avoided...
 clean::
        rm -f base/init.d-scripts/switchrunlevel

Attachment: signature.asc
Description: Digital signature

Reply via email to