On Wed, Feb 22, 2012 at 09:46:37PM +0100, Jonas Smedegaard wrote:
[..snip..]
> It makes good sense that git-import-dsc respect local config, but
> git-import-dscs not caring causes this to happen, I believe:
>
> git-import-dscs pkg
> git-import-dsc pkg-01 (initial, containing local config)
> git-import-dsc pkg-02 (loads local config from pkg-01)
Yes, that's what happens and I can understand that one wants to override
it.
>
> In effect, git-import-dscs - which was initiated with *no* local config,
> changing behaviour for pkg-02 due to pkg-01 introducing a local config.
>
> I believe in *no* situation would anyone want git-import-dscs to change
> behaviour mid-way.
>
> I therefore believe that the correct approach is for git-import-dscs to
> not simply leave it to each invocation of git-import-dsc to resolve
> local options, but instead a) resolve options itself and then b)
> explicitly set those when invoking git-import-dsc to ensure that all of
> them behave the same.
>
> Hope it makes sense, and (obviously) that you agree,
What about this approach:
* make git-import-dsc (and in fact all other tools too except for
git-import-dscs) honor a GBP_CONF_PATH variable, that defaults to the
current hardcoded set in gbp/config.py:
GBP_CONF_PATH="/etc/git-buildpackage/gbp.conf:~/.gbp.conf:.gbp.conf:debian/gbp.conf:.git/gbp.conf"
* Add a --no-pkg-config option to git-import-dscs that removes all
relative paths from the above list (Relative paths are relative
are relative to the packaging dir not to the current dir)
This way we wouldn't have to make git-import-dscs aware of all the
options git-import-dsc understands (having to keep this in sync) and
we'd also gain the possibility to ignore packaging config in other tools
too by overriding the env var. Does this make sense?
Cheers,
-- Guido
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
