On 12-02-22 at 07:55pm, Guido Günther wrote: > On Wed, Feb 22, 2012 at 07:17:16PM +0100, Jonas Smedegaard wrote: > > the frei0r packaging contains a gbp.conf with non-default branches. > > > > This fails: > > > > git-import-dscs --debsnap --pristine-tar --sign-tags frei0r > > > > This succeeds, but commits are spread across multiple branches: > > > > git-import-dscs --debsnap --pristine-tar --sign-tags > > --create-missing-branches frei0r > > > > This succeeds and looks sane: > > > > git-import-dscs --debsnap --pristine-tar --sign-tags > > --create-missing-branches --upstream-branch=upstream frei0r > > git-import-dscs doesn't care at all. git-import-dsc does indeed care > about any gbp.conf it finds and I wonder why shouldn't? You always have > the chance to override it. This is meant to make sure you get the > correct result when doing a: > > * ipmort first version > * cd into new archive > * import next version
It makes good sense that git-import-dsc respect local config, but
git-import-dscs not caring causes this to happen, I believe:
git-import-dscs pkg
git-import-dsc pkg-01 (initial, containing local config)
git-import-dsc pkg-02 (loads local config from pkg-01)
In effect, git-import-dscs - which was initiated with *no* local config,
changing behaviour for pkg-02 due to pkg-01 introducing a local config.
I believe in *no* situation would anyone want git-import-dscs to change
behaviour mid-way.
I therefore believe that the correct approach is for git-import-dscs to
not simply leave it to each invocation of git-import-dsc to resolve
local options, but instead a) resolve options itself and then b)
explicitly set those when invoking git-import-dsc to ensure that all of
them behave the same.
Hope it makes sense, and (obviously) that you agree,
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
