Package: qemu
Version: 1.0+dfsg-3
Severity: minor
Tags: patch

Dear maintainers,

I tried backporting the new qemu to squeeze today and the compile failed on 
three lines of makefile code. This took some time to find out, but it boils 
down to the dpkg-buildflags command not being expanded correctly during 
configure.

Please apply the attached patch to remove the backticks and replace them by 
$(shell) invocations.

This fixes the build and is cleaner, since the commands are now only executed 
once, instead of at every invocation of gcc.

Thanks,

Allard Hoeve


-- System Information:
Debian Release: 6.0.3
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF8, LC_CTYPE=en_US.UTF8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF8)
Shell: /bin/sh linked to /bin/dash
diff --git a/debian/rules b/debian/rules
index 4e0c888..0f17ed6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,10 +7,10 @@
 DEB_VERSION := $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' ')
 
 # Compiler flags
-CFLAGS = `dpkg-buildflags --get CFLAGS`
-LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
+LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
 LDFLAGS += -Wl,--as-needed
-CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+CFLAGS += $(shell dpkg-buildflags --get CPPFLAGS)
 
 # Support multiple makes at once
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))

Reply via email to