Hi Moritz
Thanks for the report and patch. Just to check, what is the purpose of
this? I have not followed recent discussions so I may need a pointer. :-)
// Ola
On Sun, Jan 22, 2012 at 03:13:26PM +0100, Moritz Muehlenhoff wrote:
> Source: vnc4
> Severity: important
> Tags: patch
>
> Please enabled hardened build flags through dpkg-buildflags.
>
> Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)
>
> Cheers,
> Moritz
> diff -aur vnc4-4.1.1+X4.3.0.harden/debian/rules vnc4-4.1.1+X4.3.0/debian/rules
> --- vnc4-4.1.1+X4.3.0.harden/debian/rules 2012-01-21 18:54:33.000000000
> +0100
> +++ vnc4-4.1.1+X4.3.0/debian/rules 2012-01-21 18:56:29.000000000 +0100
> @@ -16,24 +16,19 @@
> # This has to be exported to make some magic below work.
> export DH_OPTIONS
>
> -
> -
> -CFLAGS = -Wall -g
> -CXXFLAGS = -Wall -g
> -
> -ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
> - CFLAGS += -O0
> - CXXFLAGS += -O0
> -else
> - CFLAGS += -O2
> -endif
> +CFLAGS = `dpkg-buildflags --get CFLAGS`
> +CFLAGS += -Wall
> +CXXFLAGS = `dpkg-buildflags --get CXXFLAGS`
> +CXXFLAGS += -Wall
> +LDFLAGS = `dpkg-buildflags --get LDFLAGS`
> +CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`
>
> configure: configure-unix-stamp configure-common-stamp
>
> configure-common-stamp:
> dh_testdir
> # Add here commands to configure the package.
> - (cd common; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" ./configure \
> + (cd common; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)"
> CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \
> --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
> --prefix=/usr --mandir=\$${prefix}/share/man \
> --infodir=\$${prefix}/share/info \
> @@ -43,7 +38,7 @@
> configure-unix-stamp:
> dh_testdir
> # Add here commands to configure the package.
> - (cd unix; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" ./configure \
> + (cd unix; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)"
> CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \
> --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
> --prefix=/usr --mandir=\$${prefix}/share/man \
> --infodir=\$${prefix}/share/info \
> Nur in vnc4-4.1.1+X4.3.0/debian: rules~.
>
>
--
--------------------- Ola Lundqvist ---------------------------
/ o...@debian.org Annebergsslingan 37 \
| o...@inguza.com 654 65 KARLSTAD |
| http://inguza.com/ +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
