Source: vnc4 Severity: important Tags: patch Please enabled hardened build flags through dpkg-buildflags.
Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS) Cheers, Moritz
diff -aur vnc4-4.1.1+X4.3.0.harden/debian/rules vnc4-4.1.1+X4.3.0/debian/rules --- vnc4-4.1.1+X4.3.0.harden/debian/rules 2012-01-21 18:54:33.000000000 +0100 +++ vnc4-4.1.1+X4.3.0/debian/rules 2012-01-21 18:56:29.000000000 +0100 @@ -16,24 +16,19 @@ # This has to be exported to make some magic below work. export DH_OPTIONS - - -CFLAGS = -Wall -g -CXXFLAGS = -Wall -g - -ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) - CFLAGS += -O0 - CXXFLAGS += -O0 -else - CFLAGS += -O2 -endif +CFLAGS = `dpkg-buildflags --get CFLAGS` +CFLAGS += -Wall +CXXFLAGS = `dpkg-buildflags --get CXXFLAGS` +CXXFLAGS += -Wall +LDFLAGS = `dpkg-buildflags --get LDFLAGS` +CPPFLAGS = `dpkg-buildflags --get CPPFLAGS` configure: configure-unix-stamp configure-common-stamp configure-common-stamp: dh_testdir # Add here commands to configure the package. - (cd common; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" ./configure \ + (cd common; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \ --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \ --prefix=/usr --mandir=\$${prefix}/share/man \ --infodir=\$${prefix}/share/info \ @@ -43,7 +38,7 @@ configure-unix-stamp: dh_testdir # Add here commands to configure the package. - (cd unix; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" ./configure \ + (cd unix; CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \ --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \ --prefix=/usr --mandir=\$${prefix}/share/man \ --infodir=\$${prefix}/share/info \ Nur in vnc4-4.1.1+X4.3.0/debian: rules~.