Hello David, On Sat, Nov 19, 2011 at 11:08:54PM -0400, David Prévot wrote: > On 19/11/2011 09:48, Helge Kreutzmann wrote: > > On Tue, Nov 08, 2011 at 12:56:23PM -0400, David Prévot wrote: > >> Fine for me, I think other active po4a contributors are following the > >> BTS too, I just CCed the po4a upstream developers list to make sure of > >> that. For future typos, providing an actual patch[es serie] one could > >> review and acknowledge directly would be even more welcome, you may send > >> them directly to <po4a-de...@lists.alioth.debian.org> (it's a low > >> traffic list you may consider subscribing to). > > > > I just checked in a new version (which seems to have caused a > > problem[1]?) and have found some more typos/improvement possibilites. > > However, this raises two problems: > > > > a) Often I would like to explain the change (e.g. "I'm unsure" or > > "merge with" or ...), how should I do this in the patch? > > That's the beauty with patches series: it's possible to actually prepare > atomic commits, with one change by commit, and a meaningful commit > message for each change. Other people can then acknowledge (or not) the > whole series, or each individual commit, eventual amending those some of > them, making quite easy the task to apply them ones agreed.
You mean I should create a patch for each single typo/change? That's
to much work, I guess.
> That's actually one of the reason why I use “git svn”: it allows to
> prepare the changes, eventually reorder them (and even merge similar
> ones) with “git rebase -i”, and propose them (or directly commit them as
> I did with your previous proposals I had no doubt with). It makes it
> easier to revert a specific commit if someone disagrees afterward too.
Fine, but currently I've no time to learn "git svn".
> You can then prepare the patch series with “git format-patch” and send
> them directly to the list or the bug report with “git send-email” (no
> attachment needed ;-).
You know much more git than me. I'm happy with the basic commands and
an occasional swiching of a branch (in case I need to apply a fix to a
previous version as well).
> [ I must admit that I'm still discovering Git, which seems like a pretty
> efficient toy, and I can't stop playing with it. ]
I'd like too, but time constrains.
> Even after a simple “svn diff > fixes.patch”, one can add comments in
> the mail or bug report, quoting part or all of the diff in the message,
> and also attach the file in order to ease the reviewing process.
I'll probably go this route.
> I guess you could even prepare a review branch in the po4a tree (I did
> something like that a year ago, when I prepared a huge review of
> typographic and convention stuff of the documentation).
Nope, branching in CVS (and svn for that matter) is way out of my
knowledge pool.
> > I'm not
> > sure I can dig out all commenting methods properly? Do you think
> > keeping the previous style would be possible?
>
> I'm not sure I understood, could you please rephrase?
The easiest way for me is to copy the strings/lines which require
changes from de.po and add an explanation. Quick and simple for me,
but more cumbersome for you.
I just commited the latest de.po and will try to send you the diff
later today with my suggested fixes.
> Anyway, we'll send a mail to translators with incomplete translation at
> least ten days before the next release.
This is great.
> Well, it's quite self explained: too big messages don't go to the commit
> list. I don't think it's really an issue: too big changes are generally
No problem for me, I just wanted to let you know.
Greetings
Helge
--
Dr. Helge Kreutzmann deb...@helgefjell.de
Dipl.-Phys. http://www.helgefjell.de/debian.php
64bit GNU powered gpg signed mail preferred
Help keep free software "libre": http://www.ffii.de/
signature.asc
Description: Digital signature
