Package: conkeror Version: 0.9.4-1 Severity: normal Tags: patch Hi there!
Cc:ing the Mozilla maintainers for their information. xulrunner-10.0~a2 seems to have changed the format of the GRE version string, now also including the alpha number (this was not true for xulrunner-9.0~a2). This means that the check for xulrunner's version in /usr/bin/conkeror is broken and cannot be simply adapted to 10.0: ===== $ dpkg-query -W xulrunner-9.0 xulrunner-9.0 9.0~b1-1 $ xulrunner-9.0 --gre-version 9.0 $ expr `xulrunner-9.0 --gre-version | cut -d . -f 1,2` '>=' 1.9 1 $ dpkg-query -W xulrunner-10.0 xulrunner-10.0 10.0~a2+20111114042039-1 $ xulrunner-10.0 --gre-version 10.0a2 $ expr `xulrunner-10.0 --gre-version | cut -d . -f 1,2` '>=' 1.9 0 ===== Given that there is no unversioned xulrunner in Debian (see #648972), that upstream minimum requirement is xulrunner-1.9.1 [1] (xulrunner-1.9 already in lenny) and that Ubuntu does not ship any /usr/bin/xulrunner* at all [2], I would avoid at all to check for the version number. And I would also avoid to repeat 'xulrunner-' for each version and simply use the version number in the for list.he [1] <http://repo.or.cz/w/conkeror.git/commitdiff/e3bcf7053359a91d3047af129b49d0aea855a8c9> [2] <http://repo.or.cz/w/conkeror.git/commitdiff/0ef677f1f19a9725bee509760f810930d5af2d00> Here is a working-for-me patch against upstream /usr/bin/conkeror: --8<---------------cut here---------------start------------->8--- --- debian_conkeror.bin.ORG 2011-11-18 19:50:28.302405171 +0100 +++ debian_conkeror.bin 2011-11-18 19:52:08.952862490 +0100 @@ -4,24 +4,11 @@ # Find an appropriate xulrunner binary XULRUNNER='' -for xr in xulrunner-8.0 xulrunner-7.0 xulrunner-6.0 xulrunner-5.0 xulrunner-2.0 xulrunner-1.9.2 xulrunner-1.9.1 xulrunner; do - XRTMP=`which $xr` +for version in 10.0 9.0 8.0 7.0 6.0 5.0 2.0 1.9.2 1.9.1; do + XRTMP=`which xulrunner-$version` if [ -n "$XRTMP" -a -x "$XRTMP" ]; then - if expr `$XRTMP --gre-version | cut -d . -f 1,2,3` '>=' 1.9.1 > /dev/null; then - # xulrunner is version 1.9 or higher, take it - XULRUNNER=$XRTMP - break - else - # xulrunner is older than version 1.9, forget it - XRTMP=/usr/lib/$xr/xulrunner - if [ -x $XRTMP ]; then - if expr `$XRTMP --gre-version | cut -d . -f 1,2,3` '>=' 1.9.1 > /dev/null; then - # xulrunner is a 1.9 version, take it - XULRUNNER=$XRTMP - break - fi - fi - fi + XULRUNNER=$XRTMP + break fi done --8<---------------cut here---------------end--------------->8--- Thx, bye, Gismo / Luca -- Package-specific info:
-- Extensions information -- Plugins information -- Addons package information -- Extensions information -- Plugins information -- Addons package information -- Extensions information -- Plugins information -- Addons package information
-- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (990, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.1.0-rc7-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages conkeror depends on: ii xulrunner-8.0 8.0-3 Versions of packages conkeror recommends: ii conkeror-spawn-process-helper 0.9.4-1 Versions of packages conkeror suggests: ii emacs-snapshot [emacsen] 1:20111104-1 -- no debconf information
pgp2Fxp2MraBq.pgp
Description: PGP signature
