Hi,

2011/5/10 Henrique de Moraes Holschuh <h...@debian.org>:

> The patch does not match the equivalent test for __ARM_EABI__ a few
> lines above.
>
> Do you really need to use the -dM gcc option?  It might not be as portable
> or something.

arm-linux-gnueabihf is quite fixed, so probably we do not need to
worry about portability.
You are right, we can avoid -dM, yesterday I got confused because I
was looking to __ARM_PCS_VFP__ instead __ARM_PCS_VFP

> If you change the patch, please retest.

hardfp:
$ echo __ARM_PCS_VFP | gcc -E - 2>/dev/null
# 1 "<stdin>"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "<stdin>"
1
$ dpkg --print-architecture
armhf

./configure (on GNU hello program with updated config.guess)
[...]
checking build system type... armv7l-unknown-linux-gnueabihf
checking host system type... armv7l-unknown-linux-gnueabihf

softfp: (Ubuntu)
$ echo __ARM_PCS_VFP | gcc -E - 2>/dev/null
# 1 "<stdin>"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "<stdin>"
__ARM_PCS_VFP
$ dpkg --print-architecture
armel

./configure (on GNU hello program with updated config.guess)
[...]
checking build system type... armv7l-unknown-linux-gnueabi
checking host system type... armv7l-unknown-linux-gnueabi

soft:
$ echo __ARM_PCS_VFP | gcc -E - 2>/dev/null
# 1 "<stdin>"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "<stdin>"
__ARM_PCS_VFP
$ dpkg --print-architecture
armel

idem above.

Here an updated patch:

diff --git a/ChangeLog b/ChangeLog
index c76e2f3..2048333 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-09  Hector Oron <zu...@debian.org>
+           Konstantinos Margaritis <mar...@debian.org>
+
+       * config.guess: Add configuration support for
+       ${UNAME_MACHINE}-unknown-linux-gnueabihf on arm targets.
+
 2011-03-31  Kirk Hays  <kh...@hayshaus.com>
            Ben Elliston  <b...@gnu.org>

diff --git a/config.guess b/config.guess
index 187cd54..d8fe13e 100755
--- a/config.guess
+++ b/config.guess
@@ -4,7 +4,7 @@
 #   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010,
 #   2011 Free Software Foundation, Inc.

-timestamp='2011-02-02'
+timestamp='2011-05-10'

 # This file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -882,7 +882,13 @@ EOF
        then
            echo ${UNAME_MACHINE}-unknown-linux-gnu
        else
-           echo ${UNAME_MACHINE}-unknown-linux-gnueabi
+           if echo __ARM_PCS_VFP | $CC_FOR_BUILD -E - 2>/dev/null \
+               | grep -q __ARM_PCS_VFP
+           then
+               echo ${UNAME_MACHINE}-unknown-linux-gnueabi
+           else
+               echo ${UNAME_MACHINE}-unknown-linux-gnueabihf
+           fi
        fi
        exit ;;
     avr32*:Linux:*:*)


Best regards
-- 
 Héctor Orón  -.. . -... .. .- -.   -.. . ...- . .-.. --- .--. . .-.

"Our Sun unleashes tremendous flares expelling hot gas into the Solar
System, which one day will disconnect us."

-- Day DVB-T stop working nicely
Video flare: http://antwrp.gsfc.nasa.gov/apod/ap100510.html



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to