Sorry for the delay in responding.

Guillem Jover <guil...@debian.org> wrote:

> The patch in #595239 seems to have introduced a regression, only
> for kfreebsd-i386, although this might imply not completely LFS safe
> operation on the rest of the 32-bit architectures. Attached is an
> updated patch which should fix it, the relevant changes are the
> switch of types for sizeheaders.

Looks like the only change is patching a few additional files.  The
patch looks fine to me, so I'm updating it.  Thanks.

> I'd also ask you to consider removing the -Werror flag, as it can
> trigger build failure on toolchain updates for example. While it's
> always good to build stuff with -Werror during development, it's not
> so much for releases and such. And although in this case it revealed
> a true problem, that might not be usually the case.

You're correct.  I'm not sure how that got in there.  I must have
inherited it from the previous maintainer. ;-)  Seriously though, I have
removed -Werror.  I agree it has no place in a release build,
particularly since psutils is more or less dead upstream.  Compiler
warnings change over time, and we don't necessarily want to have to fix
them all the time.

--Jay



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to