Hello,
On Tue, 15 Feb 2011 11:52:54 +0900
d+sylph...@vdr.jp wrote:
> > It seems that everyone crashed at the same point:
> > summaryview.c: summary_show_queued_msgs() -> summary_status_show()
> >
> > The GtkTreeStore iterator somehow became invalid there.
> > I haven't figure out the reason yet.
>
> Yeah, yesterday I reproduced it. While I opened some folder,
> I sent test mail that filtered to there, sylpheed always crashed.
> But today I could not reproduce it by same way.
> I did not change any settings. It is very strange.
It seems that I have found the cause of problem.
Please try the attached patch to see it fixes the crash.
--
Hiroyuki Yamamoto <hir...@kcn.ne.jp>
Index: src/summaryview.c
===================================================================
--- src/summaryview.c (revision 2844)
+++ src/summaryview.c (working copy)
@@ -1120,6 +1120,7 @@
summaryview->all_mlist = g_slist_concat(summaryview->all_mlist, qlist);
item->cache_dirty = TRUE;
+ summary_selection_list_free(summaryview);
summary_status_show(summaryview);
@@ -2204,10 +2205,12 @@
GtkTreeIter iter;
GtkTreePath *path = (GtkTreePath *)cur->data;
- gtk_tree_model_get_iter(model, &iter, path);
- gtk_tree_model_get(model, &iter, S_COL_MSG_INFO, &msginfo, -1);
- sel_size += msginfo->size;
- n_selected++;
+ if (gtk_tree_model_get_iter(model, &iter, path)) {
+ gtk_tree_model_get(model, &iter,
+ S_COL_MSG_INFO, &msginfo, -1);
+ sel_size += msginfo->size;
+ n_selected++;
+ }
}
if (FOLDER_TYPE(summaryview->folder_item->folder) == F_NEWS) {
