On Mon, 14 Feb 2011, Jonathan Nieder wrote:
> Missing "keys". Some other typos. The following might actually work.
> Thoughts?
You should also update the code for the source package formats
because both 1.0 and 3.0 (quilt) pass an explicit value
for the timestamp.
And your patch is heavy on the refactoring, I would rather
change it to compute the correct timestamp before the loop
in the case where no timestamp is given and otherwise not change
anything else.
if ($force_timestamp and !defined($timestamp)) {
my ($first_file) = grep { -e $_ } @files;
if ($first_file) {
utime(undef, undef, $first_file) || syserr();
my @stat = stat($first_file) || syserr();
$timestamp = $stat[9];
} else {
$timestamp = time()
}
}
I'm not sure whether stat or lstat is more appropriate. I would say stat
because the link is not modified, but the underlying file is.
Of course utime might act on the symlink but then it's not a big deal if
we reuse the timestamp of a recently modified file.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Follow my Debian News ▶ http://RaphaelHertzog.com (English)
▶ http://RaphaelHertzog.fr (Français)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
