On 10/18/2010 10:22 PM, Jonathan Nieder wrote: > Thanks! I assume you'd be willing to make sure it stays in good > shape?
i can send patches in case there are updates needed, yes. >> +++ b/debian/control > [...] >> +Conflicts: git-daemon-sysv >> +Replaces: git-daemon-sysv > > Probably a silly question, but is this Replaces: necessary? g-d-run and g-d- sysv are truly conflicting since both are shipping /etc/init.d/git-daemon, therefore, to my understanding, a conflicts/replaces is needed on both. >> + git-daemon, as provided by the git package, is a simple server for git >> + repositories, ideally suited for read-only updates, i.e. pulling from git >> + repositories through the network. This package provides a sysvinit service >> + for running git-daemon permanently. > > I think you mean persistently. :) (or "as a persistent process".) this is a copy of the description of g-d-run, if you would like to improve the package description, that should go in another commit, but not in the one adding g-d-sysv. >> +++ b/debian/git-daemon-sysv.postinst >> @@ -0,0 +1,21 @@ > [...] >> + # restart git-daemon service if it was running >> + if [ -x "`which invoke-rc.d 2>/dev/null`" ]; then >> + invoke-rc.d git-daemon start || exit $? >> + else >> + etc/init.d/git-daemon start || exit $? > > Missing leading /? that somehow got stripped out, don't know why. >> +++ b/debian/git-daemon-sysv.postrm >> @@ -0,0 +1,10 @@ >> +#!/bin/sh >> +set -e >> + >> +test "$1" = 'purge' || exit 0 >> + >> +update-rc.d git-daemon remove >/dev/null >> + >> +getent passwd gitlog >/dev/null || exit 0 >> +! deluser --version >/dev/null 2>&1 || exec deluser -f gitlog >> +echo 'deluser program not available, not removing system user "gitlog".' >&2 > > > Maybe the gitlog user should be removed at deconfigure-time. this is, apart from the update-rc.d call, a copy of g-d-run.postrm script. if you would like to improve that script, that should go in another commit, but not in the one adding g-d-sysv. >> +++ b/debian/git-daemon/default > [...] >> +GIT_DAEMON_ENABLE=false > > Yay. :) > > Maybe a README.Debian to mention this for the perplexed would be > worthwhile; not sure. the init script actually lacked the check for GIT_DAEMON_ENABLED=true. i've added that, will add a note to README.Debian, adjust (some of) above things, and send an updated patch tomorrow morning. >> +++ b/debian/git-daemon/sysv > > I'm trusting you about the init script itself. it's working well for me, and is, on purpose, as minimally as possible different from the initscript template from dh-make, so i'm pretty sure it's correct. Regards, Daniel -- Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: daniel.baum...@panthera-systems.net Internet: http://people.panthera-systems.net/~daniel-baumann/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
