Daniel Baumann wrote:
> here's a patch against 1:1.7.2.3-2 which i've applied on my local git
> packages and which i'm using successfully since some time on my own servers.
Thanks! I assume you'd be willing to make sure it stays in good
shape?
> --- a/debian/control
> +++ b/debian/control
[...]
> @@ -150,6 +150,8 @@ Description: fast, scalable, distributed revision control
> system (email add-on)
> Package: git-daemon-run
> Architecture: all
> Depends: git (>> ${source:Upstream-Version}), git (<<
> ${source:Upstream-Version}-.), runit (>= 1.8.0-2), adduser
> +Conflicts: git-daemon-sysv
> +Replaces: git-daemon-sysv
> Description: fast, scalable, distributed revision control system (git-daemon
> service)
Probably a silly question, but is this Replaces: necessary?
See http://lists.debian.org/debian-ctte/2010/05/msg00010.html for
discussion.
> @@ -165,6 +167,26 @@ Description: fast, scalable, distributed revision
> control system (git-daemon ser
[...]
> +Conflicts: git-daemon-run
> +Replaces: git-daemon-run
Likewise.
[...]
> + git-daemon, as provided by the git package, is a simple server for git
> + repositories, ideally suited for read-only updates, i.e. pulling from git
> + repositories through the network. This package provides a sysvinit service
> + for running git-daemon permanently.
I think you mean persistently. :) (or "as a persistent process".)
> --- /dev/null
> +++ b/debian/git-daemon-sysv.postinst
> @@ -0,0 +1,21 @@
[...]
> + # restart git-daemon service if it was running
> + if [ -x "`which invoke-rc.d 2>/dev/null`" ]; then
> + invoke-rc.d git-daemon start || exit $?
> + else
> + etc/init.d/git-daemon start || exit $?
Missing leading /?
> --- /dev/null
> +++ b/debian/git-daemon-sysv.postrm
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +set -e
> +
> +test "$1" = 'purge' || exit 0
> +
> +update-rc.d git-daemon remove >/dev/null
> +
> +getent passwd gitlog >/dev/null || exit 0
> +! deluser --version >/dev/null 2>&1 || exec deluser -f gitlog
> +echo 'deluser program not available, not removing system user "gitlog".' >&2
Yuck. Policy can be unpleasant sometimes. :(
Maybe the gitlog user should be removed at deconfigure-time.
> --- /dev/null
> +++ b/debian/git-daemon-sysv.prerm
> @@ -0,0 +1,13 @@
> +#!/bin/sh
> +set -e
> +
> +test "$1" = 'remove' || test "$1" = 'deconfigure' || \
> + test "$1" = 'failed-upgrade' || exit 0
> +
> +if [ -x "/etc/init.d/git-daemon" ]; then
> + if [ -x "`which invoke-rc.d 2>/dev/null`" ]; then
> + invoke-rc.d git-daemon stop || exit $?
> + else
> + etc/init.d/git-daemon stop || exit $?
Missing leading '/'?
> --- /dev/null
> +++ b/debian/git-daemon/default
[...]
> +GIT_DAEMON_ENABLE=false
Yay. :)
Maybe a README.Debian to mention this for the perplexed would be
worthwhile; not sure.
> --- /dev/null
> +++ b/debian/git-daemon/sysv
I'm trusting you about the init script itself.
Except as noted above, looks good to me.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
