Bug#595346: libnusoap-php uses deprecated return value of new by reference

[Thomas Goirand]

Olivier Berger wrote:
> severity 595346 normal
> thanks
> 
> Le vendredi 03 septembre 2010 à 17:26 +0800, Thomas Goirand a écrit :
> 
>> Hi,
>>
>> libnusoap-php produces the following warning under Squeeze, due
>> to the changes in PHP 5.3.x:
>>
>> PHP Deprecated:  Assigning the return value of new by reference is
>> deprecated in /usr/share/php/nusoap/nusoap.php on line 7384
>>
>> It would be really good if this could be fixed before Squeeze is
>> released.
> 
> This is just a warning... and how annoying it could be, doesn't mention
> that the deprecation may happen during squeeze lifetime, so not so much
> a problem IMHO.

Sorry, but I do not agree with the above. A simple warning can have
grave consequences. For example, we include nusoap.php in a cron job
that starts every 10 minutes. With this issue, I was spammed every 10
minutes by this cron job because of this warning.

Another example of bad issue with a warning would be a program that
would generate a document like an XML. If there was a warning, then this
would render the the XML document totally wrong.

There are many other examples...

>>  Please consider either packaging the latest version from
>> upstream (if it corrects the issue), or patching the currently
>> existing package.
>>
> 
> Have you seen http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577441#30
> and tested anything on the version in experimental (which may be
> uploaded to unstable I guess, now) ?

I didn't see it, no. A quick search on the archive shows that Squeeze
and SID have the same old version:

http://packages.debian.org/search?keywords=nusoap&searchon=names&suite=all&section=all

> I'm basically preferring to have deprecation warnings instead of soap
> breakages, until apps have been tested more.

I basically want something that works, without warnings, especially when
the fix are quite simple. If you want to keep the old version (which I
think is a good idea), you can patch it to fix the issues, this isn't so
much of a problem. Please have a look at the extremely easy fix that we
are talking about, and that I've attached to this email: we are talking
about remove exactly *one character* in the source code... :)

Please let me know what you think about this.

Thomas

--- nusoap.php.orig	2010-09-04 00:51:44.000000000 +0800
+++ nusoap.php	2010-09-04 00:52:09.000000000 +0800
@@ -7381,7 +7381,7 @@
 	 */
 	function loadWSDL() {
 		$this->debug('instantiating wsdl class with doc: '.$this->wsdlFile);
-		$this->wsdl =& new wsdl('',$this->proxyhost,$this->proxyport,$this->proxyusername,$this->proxypassword,$this->timeout,$this->response_timeout,$this->curl_options,$this->use_curl);
+		$this->wsdl = new wsdl('',$this->proxyhost,$this->proxyport,$this->proxyusername,$this->proxypassword,$this->timeout,$this->response_timeout,$this->curl_options,$this->use_curl);
 		$this->wsdl->setCredentials($this->username, $this->password, $this->authtype, $this->certRequest);
 		$this->wsdl->fetchWSDL($this->wsdlFile);
 		$this->checkWSDL();