tag 580545 + wontfix thanks Hi Tobias,
thanks for your bug report! On Thu, May 06, 2010 at 07:47:47PM +0200, Tobias Grimm wrote: > When tagging, the BASE revision is tagged which might not be the > current revision of the working directory. > > E.g. when checking out r8614 (making BASE=8614) then commiting changes > that become r8615 (BASE is still 8614!!!) then tagging with > svn-buildpackage which does a "-rBASE cp . svn://.." r8614 will be > tagged instead of r8615! That is true but I think it's the user's responsibility to keep his working directory up to date. > A workaround would be to do a "svn up" to update BASE of the local working dir > before tagging with svn-buildpackage. That might be worth considering but I don't think it's generally a good idea to decide for the user what revision he wants to have checked out. Think about running 'svn-buildpackage --svn-only-tag' on an old revision just because you forgot tagging back then. 'svn up' would mess that up pretty much. > To fix the problem, I suggest to remove "-rBASE" from the tagging commands. > Please see the attached patch. Actually, that was introduced in the recent upload exactly to achieve what you want to avoid here. svn-buildpackage should not try to tag anything but what the user checked out. Before 0.8.0 it tagged HEAD, i.e. the remote state, which was bad, too. I guess having to choose here is how subversion was designed. As a consequence I consider this bug won't-fix. > Hope this was helpful, It was. Thanks! Hauke -- .''`. Jan Hauke Rahm <j...@debian.org> www.jhr-online.de : :' : Debian Developer www.debian.org `. `'` Member of the Linux Foundation www.linux.com `- Fellow of the Free Software Foundation Europe www.fsfe.org
signature.asc
Description: Digital signature
