tags 578773 patch
thanks

On Thu, Apr 22, 2010 at 07:04:51PM +0300, Julian Gilbey wrote:
> Package: gcompris
> Version: 9.2-2-1
> Severity: normal
> 
> Fascinating problem: the correct sequence was something like
> red-cyan-green.  With the input red-blue-green, the computer put a
> black around the red and green and a white around the blue.

Found the bug - it was an array overflow/off-by-one error.  Here is a
patch (the file is src/superbrain-activity/superbrain.c):

--- superbrain.c.orig   2010-04-22 20:14:39.000000000 +0300
+++ superbrain.c        2010-04-22 20:15:10.000000000 +0300
@@ -558,7 +558,7 @@
              g_object_set (piece->misplaced, "visibility", 
GOO_CANVAS_ITEM_VISIBLE, NULL);
            done = TRUE;
          }
-      } while (!done && j++!=number_of_piece);
+      } while (!done && ++j!=number_of_piece);
     }
 
   /* Display the matermind information to the user */


   Julian



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to