Package: dh-make
Version: 0.52
Severity: wishlist

(FYI: maint-guide uploaded with many changes by you.  Thanks.)

It seems dh-make makes dpkg 3.0 quilt as default.
This is a bit of jump from the previous behavior.

I think it is better to have "3.0 (native)" as default.  Then it works
almost as if old one.  It skips .git etc for tar ball so these are
improvements.

If you insist "3.0 (quilt)" here, "Build-Depends: debhelper (>= 7)" should
include "quilt".  (per http://wiki.debian.org/Projects/DebSrc3.0 )

debhelper (7.0.50) unstable; urgency=low

  * This release is designed to be easily backportable to stable,
    to support the new style of rules file that I expect many packages will
    use.
  * dh: debian/rules override targets can change what is run
    for a specific debhelper command in a sequence.
    (Thanks Modestas Vainius for the improved makefile parser.)
  * dh: Redid all the examples to use override targets, since these
    eliminate all annoying boilerplate and are much easier to understand
    than the old method.
...

Oh, it seems "debhelper (>= 7)" is not good default.  Lintian recommend
debhelper (>= 7.0.50) which is new enough to support dh syntax well.
Since you use dh, we need to do so.

Also using quilt seem to need some funky make file modification ... I
have not done this but this page seems credible.  
http://wiki.debian.org/HolgerLevsen

  adding patches with quilt to a package

   1. add quilt to build-depends
   2. create debian/patches/ and put the patches there
   3.  cd debian/patches ; ls > series
   4.  add "QUILT_PATCHES=debian/patches quilt push -a || test $$? = 2" to the 
configure target in debian/rules
   5.  add "QUILT_PATCHES=debian/patches quilt pop -a -R || test $$? = 2" to 
the clean target in debian/rules
   6.  enjoy :)

But Raphael Hertzog states in http://wiki.debian.org/Projects/DebSrc3.0

You should remove everything related to quilt in debian/rules (patch/unpatch 
logic, cleanup of quilt stamp file and its .pc directory). Note that if you 
keep those rules, you must unpack the source package with a recent version of 
dpkg (>= 1.15.5.4) to ensure that dpkg-source creates the .pc files that quilt 
itself expects. Be aware that some buildds (running an old sbuild) do unpack 
the source package outside of the build chroot (on a lenny system running an 
old version of dpkg << 1.14.28), so keeping those rules will make the package 
fail to build on those buildds.

So I do not know what dh-make should do.

Aside from which one should be default, they should be selectable
feature.  I suggest following option to make these selectable.
 -3 n | -3 native
 -3 q | -3 quilt
 ...
with this we can accept git etc.

Also interactive screen, this choice should be asked with ample guiding
dialogue too.

Anyway, When I was making upload of maint-guide, I realized all these.

Once we sort these up, main story of maint-guide should be made to use
"3.0 (native)".  Then dpatch section should be replaced with example to
use "3.0 (quilt)" format.

Any thought?

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dh-make depends on:
ii  debhelper                     7.4.15     helper programs for debian/rules
ii  dpkg-dev                      1.15.5.6   Debian package development tools
ii  make                          3.81-7     An utility for Directing compilati
ii  perl                          5.10.1-11  Larry Wall's Practical Extraction 

dh-make recommends no packages.

Versions of packages dh-make suggests:
ii  build-essential               11.4       Informational list of build-essent

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to