Package: pfstools Version: 1.8.1-1 Severity: important Tags: patch Justification: fails to build from source User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu karmic ubuntu-patch
Hi, When compiling pfstools for Karmic, we got the following compilation error: i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I./../pfs -O3 -Wall -MT pfspanoramic.o -MD -MP -MF .deps/pfspanoramic.Tpo -c -o pfspanoramic.o pfspanoramic.cpp pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateX(double)': pfspanoramic.cpp:108: warning: no return statement in function returning non-void pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateY(double)': pfspanoramic.cpp:122: warning: no return statement in function returning non-void pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateZ(double)': pfspanoramic.cpp:136: warning: no return statement in function returning non-void pfspanoramic.cpp: In static member function 'static Projection* ProjectionFactory::getProjection(const char*)': pfspanoramic.cpp:198: error: invalid conversion from 'const char*' to 'char*' pfspanoramic.cpp:198: warning: suggest parentheses around assignment used as truth value pfspanoramic.cpp: In member function 'virtual Vector3D* MirrorBallProjection::uvToDirection(double, double)': pfspanoramic.cpp:279: warning: unused variable 't' pfspanoramic.cpp: In member function 'virtual Vector3D* AngularProjection::uvToDirection(double, double)': pfspanoramic.cpp:397: warning: unused variable 't' pfspanoramic.cpp: In function 'void panoramic(int, char**)': pfspanoramic.cpp:794: warning: unused variable 'dX' pfspanoramic.cpp:794: warning: unused variable 'dY' pfspanoramic.cpp:794: warning: unused variable 'dZ' make[4]: *** [pfspanoramic.o] Error 1 make[4]: Leaving directory `/build/buildd/pfstools-1.8.1/src/filter' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/build/buildd/pfstools-1.8.1/src' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/build/buildd/pfstools-1.8.1' make[1]: *** [all] Error 2 make[1]: Leaving directory `/build/buildd/pfstools-1.8.1' make: *** [build-stamp] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 Upstream proposed the fix in the attached patch at http://sourceforge.net/tracker/index.php?func=detail&aid=2848391&group_id=129921&atid=716245 and should be apply to Debian also, to avoid compilation a compilation error with latest gcc 4.4 and glibc 2.10. Thanks, Fabrice *** /tmp/tmptnQa0k In Ubuntu, we've applied the attached patch to achieve the following: * debian/patches/gcc-4.4.dpatch: fix line 194 of src/filter/pfspanoramic.cpp to avoid a compilation error (LP: #429629) * debian/patches/00list: added gcc-4.4.dpatch We thought you might be interested in doing the same. -- System Information: Debian Release: squeeze/sid APT prefers karmic-updates APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic') Architecture: amd64 (x86_64) Kernel: Linux 2.6.31-14-generic (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash
diff -u pfstools-1.8.1/debian/patches/00list pfstools-1.8.1/debian/patches/00list --- pfstools-1.8.1/debian/patches/00list +++ pfstools-1.8.1/debian/patches/00list @@ -2,2 +2,3 @@ octave-signal.dpatch +gcc-4.4.dpatch only in patch2: unchanged: --- pfstools-1.8.1.orig/debian/patches/gcc-4.4.dpatch +++ pfstools-1.8.1/debian/patches/gcc-4.4.dpatch @@ -0,0 +1,19 @@ +#! /bin/sh /usr/share/dpatch/dpatch-run +## gcc-4.4.dpatch by Fabrice Coutadeur <fabric...@ubuntu.com> +## +## All lines beginning with `## DP:' are a description of the patch. +## DP: Fix compilation error with GCC 4.4. Fix get from http://sourceforge.net/tracker/index.php?func=detail&aid=2848391&group_id=129921&atid=716245 + +...@dpatch@ +diff -urNad pfstools-1.8.1~/src/filter/pfspanoramic.cpp pfstools-1.8.1/src/filter/pfspanoramic.cpp +--- pfstools-1.8.1~/src/filter/pfspanoramic.cpp 2008-07-29 16:14:30.000000000 +0000 ++++ pfstools-1.8.1/src/filter/pfspanoramic.cpp 2009-09-10 20:11:29.000000000 +0000 +@@ -191,7 +191,7 @@ + singleton.projections[ string( name ) ] = ptr; + } + +- static Projection *getProjection(const char *name) ++ static Projection *getProjection(char *name) + { + char *opts; +
