Package: amarok
Version: 1.4.10-3~
Severity: normal
Tags: patch

Hi.

Amarok 1.4 in stable is broken because it doesn't show content from
wikipedia about the artists. The only part shown is the list of
languages that the article is translated to, which is, sincerely,
useless.

The patch attached fixes this. Inspired by discussions from Ubuntu, at
https://bugs.launchpad.net/ubuntu/+source/amarok/+bug/316140/

BTW, I *just* discovered that this bug really affects a lot of people,
as there are also people in Gentoo experiencing the problem:
http://bugs.gentoo.org/show_bug.cgi?id=256389

And more:
http://forum.intilinux.com/software-39/*hint*-amarok-and-wikipedia/

The latter link is to a web forum, but it is useless for people that use
production machines with other architectures (let alone talking about
the risks of using precompiled binaries from unsigned sources).

The patch is already applied, refreshed, compiled, tested, and working.


Thanks, Rogério Brito.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-rc5-1-00053-gd995053 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf-8, LC_CTYPE=pt_BR.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages amarok depends on:
ii  amarok-common        1.4.10-3~           architecture independent files for
ii  amarok-engine-xine   1.4.10-3~           Xine engine for the Amarok audio p
ii  kdelibs4c2a          4:3.5.10.dfsg.1-2.1 core libraries and binaries for al
ii  libc6                2.10.1-4            GNU C Library: Shared libraries
ii  libgcc1              1:4.4.2-1           GCC support library
ii  libgl1-mesa-glx [lib 7.6-1               A free implementation of the OpenG
ii  libglib2.0-0         2.22.2-2            The GLib library of C routines
ii  libgpod3             0.6.0-6             library to read and write songs an
ii  libifp4              1.0.0.2-3           communicate with iRiver iFP audio 
ii  libkarma0            0.0.6-4             Rio Karma access library [runtime 
ii  libmtp7              0.2.6.1-3           Media Transfer Protocol (MTP) libr
ii  libmysqlclient15off  5.0.51a-24+lenny2   MySQL database client library
ii  libnjb5              2.2.5-4.2           Creative Labs Nomad Jukebox librar
ii  libpq5               8.4.1-1             PostgreSQL C client library
ii  libqt3-mt            3:3.3.8b-6          Qt GUI Library (Threaded runtime v
ii  libruby1.8           1.8.7.174-2         Libraries necessary to run Ruby 1.
ii  libsdl1.2debian      1.2.13-5            Simple DirectMedia Layer
ii  libsqlite3-0         3.6.19-3            SQLite 3 shared library
ii  libstdc++6           4.4.2-1             The GNU Standard C++ Library v3
ii  libtag1c2a           1.6-3               TagLib Audio Meta-Data Library
ii  libtunepimp5         0.5.3-7+b1          MusicBrainz tagging library
ii  libusb-0.1-4         2:0.1.12-13         userspace USB programming library
ii  libvisual-0.4-0      0.4.0-2.1           Audio visualization framework
ii  unzip                6.0-1               De-archiver for .zip files

Versions of packages amarok recommends:
pn  amarok-konqsidebar            <none>     (no description available)
pn  kdemultimedia-kio-plugins     <none>     (no description available)

Versions of packages amarok suggests:
pn  amarok-engines              <none>       (no description available)
ii  elinks-lite [www-browser]   0.12~pre5-1  advanced text-mode WWW browser - l
ii  iceweasel [www-browser]     3.5.4-1      lightweight web browser based on M
pn  libvisual-0.4-plugins       <none>       (no description available)
ii  lynx-cur [www-browser]      2.8.8dev.1-1 Text-mode WWW Browser with NLS sup
pn  moodbar                     <none>       (no description available)

-- no debconf information

-- 
Rogério Brito : rbr...@{mackenzie,ime.usp}.br : GPG key 1024D/7C2CAEB8
http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito
Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org
--- a/amarok/src/contextbrowser.cpp
+++ b/amarok/src/contextbrowser.cpp
@@ -4189,13 +4189,15 @@
     }
 
     // Ok lets remove the top and bottom parts of the page
-    m_wiki = m_wiki.mid( m_wiki.find( "<h1 class=\"firstHeading\">" ) );
+    m_wiki = m_wiki.mid( m_wiki.find( "<h1 " ) );
     m_wiki = m_wiki.mid( 0, m_wiki.find( "<div class=\"printfooter\">" ) );
     // Adding back license information
     m_wiki += copyright;
     m_wiki.append( "</div>" );
     m_wiki.replace( QRegExp("<h3 id=\"siteSub\">[^<]*</h3>"), QString::null );
-
+    m_wiki.replace( QRegExp("<div id=\"jump-to-nav\">Jump to: "
+			    "<a href=\"#column-one\">navigation</a>, "
+			    "<a href=\"#searchInput\">search</a></div>"), QString::null );
     m_wiki.replace( QRegExp( "<span class=\"editsection\"[^>]*>[^<]*<[^>]*>[^<]*<[^>]*>[^<]*</span>" ), QString::null );
 
     m_wiki.replace( QRegExp( "<a href=\"[^\"]*\" class=\"new\"[^>]*>([^<]*)</a>" ), "\\1" );

Reply via email to