Hi,

First of all, thanks a lot for the bug reports. I was in fact, waiting
and hoping that somebody corrects me. If nobody did, I would have ask in
places like -mentors, etc. Note that I've applied your patch in my Git
already.

Let me comment, and maybe ask few questions, because I'm not 100% sure
here, and I didn't find a document that would be authoritative about it.
Opposed to that, I have found many examples that seemed wrong to me.

Petter Reinholdtsen wrote:
> This patch should solve the issue.  Without it, the script will start
> to early in the boot sequence, and the two packages
> mysqmail-dovecot-logger and mysqmail-courier-logger will fail to
> install if the other was installed earlier.

Is this solved by your patch?

While it's important that syslog is started before mysqmail, it's not an
absolute necessity, as MySQMail is using tail -F (retry mode of tail) to
read the syslog file. Do you think I should still depend on it in my
boot sequence header? Or is it better to NOT depend on it, so that
things could be started at the same time in the future?

Also, in my init script, I do:

start)
        if [ ! -f ${PID_FILE} ] ; then
                log_daemon_msg "Starting ${DESC}" "${NAME}"
                start-stop-daemon -S --quiet -p ${PID_FILE} --exec ${DAEMON}
                RET=$?
                log_end_msg $?
        else
                echo "${PID_FILE} already exists: not starting ${DAEMON}"
        fi
        exit ${RET}
;;
stop)
        if [ -f ${PID_FILE} ] ; then
                log_daemon_msg "Stopping ${DESC}" "${NAME}"
                start-stop-daemon -K --quiet -p ${PID_FILE}
                RET=$?
                log_end_msg $?
        else
                echo "${PID_FILE} doesn't exist: not stoping ${DAEMON}"
        fi

Did you see that the stop) script doesn't exit with error, as I found it
problematic (like, I had an issue with a broken version of MySQMail,
exiting with error would render the upgrade impossible). I'm not 100%
sure what to do here.

Also, currently, the debconf templates are to be reviewed by -i18n. Do
you think the upload of the corrected init scripts are urgent, and
should not wait for the new English templates?

Thanks again for your comments and your care about my package,

Thomas




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to