Package:  mysqmail
Version:  0.4.7-1
Severity: important
Tags:     patch
User:     initscripts-ng-de...@lists.alioth.debian.org
Usertags: incorrect-provides incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The script need files in /usr/ and should
depend on $remote_fs, and also seem to use syslog and should depend on
$syslog.  The provides should be unique, and the
mysqmail-dovecot-logger provide conflicts with the
mysqmail-courier-logger one.

<URL: 
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
 >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the script will start
to early in the boot sequence, and the two packages
mysqmail-dovecot-logger and mysqmail-courier-logger will fail to
install if the other was installed earlier.

diff -ur mysqmail-0.4.7-pere/debian/mysqmail-courier-logger.init 
mysqmail-0.4.7/debian/mysqmail-courier-logger.init
--- mysqmail-0.4.7-pere/debian/mysqmail-courier-logger.init     2009-09-09 
22:29:13.000000000 +0200
+++ mysqmail-0.4.7/debian/mysqmail-courier-logger.init  2009-09-09 
22:30:46.000000000 +0200
@@ -2,10 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:          mysqmail-courier-logger
-# Required-Start:
-# Required-Stop:
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: MySQL accouting for courier-imap and courier-pop
diff -ur mysqmail-0.4.7-pere/debian/mysqmail-dovecot-logger.init 
mysqmail-0.4.7/debian/mysqmail-dovecot-logger.init
--- mysqmail-0.4.7-pere/debian/mysqmail-dovecot-logger.init     2009-09-09 
22:29:13.000000000 +0200
+++ mysqmail-0.4.7/debian/mysqmail-dovecot-logger.init  2009-09-09 
22:32:24.000000000 +0200
@@ -1,11 +1,9 @@
 #!/bin/sh

 ### BEGIN INIT INFO
-# Provides:          mysqmail-courier-logger
-# Required-Start:
-# Required-Stop:
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Provides:          mysqmail-dovecot-logger
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: MySQL accouting for courier-imap and courier-pop
diff -ur mysqmail-0.4.7-pere/debian/mysqmail-postfix-logger.init 
mysqmail-0.4.7/debian/mysqmail-postfix-logger.init
--- mysqmail-0.4.7-pere/debian/mysqmail-postfix-logger.init     2009-09-09 
22:29:13.000000000 +0200
+++ mysqmail-0.4.7/debian/mysqmail-postfix-logger.init  2009-09-09 
22:31:16.000000000 +0200
@@ -2,10 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:          mysqmail-postfix-logger
-# Required-Start:
-# Required-Stop:
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: A MySQL traffic logger for the Postfix SMTP
diff -ur mysqmail-0.4.7-pere/debian/mysqmail-pure-ftpd-logger.init 
mysqmail-0.4.7/debian/mysqmail-pure-ftpd-logger.init
--- mysqmail-0.4.7-pere/debian/mysqmail-pure-ftpd-logger.init   2009-09-09 
22:29:13.000000000 +0200
+++ mysqmail-0.4.7/debian/mysqmail-pure-ftpd-logger.init        2009-09-09 
22:31:30.000000000 +0200
@@ -2,10 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:          mysqmail-pure-ftpd-logger
-# Required-Start:
-# Required-Stop:
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: A MySQL traffic logger for the pure-ftpd transfer.log
diff -ur mysqmail-0.4.7-pere/debian/mysqmail-qmail-logger.init 
mysqmail-0.4.7/debian/mysqmail-qmail-logger.init
--- mysqmail-0.4.7-pere/debian/mysqmail-qmail-logger.init       2009-09-09 
22:29:13.000000000 +0200
+++ mysqmail-0.4.7/debian/mysqmail-qmail-logger.init    2009-09-09 
22:31:41.000000000 +0200
@@ -2,10 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:          mysqmail-qmail-logger
-# Required-Start:
-# Required-Stop:
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: A MySQL traffic logger for the pure-ftpd transfer.log

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to