Hi, On Sat, Aug 22, 2009 at 02:28:46AM +0200, Florian Forster wrote: > On Fri, Aug 21, 2009 at 03:51:55PM -0400, Joey Hess wrote: > > Severity: normal > > [...] > > - Accidentially still powered on laptop melts in its bag or causes > > plane to crash into Hudson river. ;-)
Uhm ... I think we should introduce a new severity "threat-for-humanity" for that ;-) > > And that *is* a bug, I'm sure. dh.c runs this code much later than > > seems to be necessary: > > > > if (ignorelist_match (il_fstype, mnt_ptr->type)) > > continue; > > if (ignorelist_match (il_mountpoint, mnt_ptr->dir)) > > continue; > > > > I think that should definitly be moved to above the statfs call. And > > then I *suggest* the default config be changed to something like: > > > > <Plugin df> > > FSType "nfs" > > IgnoreSelected true > > </Plugin> > > Right. Fixed upstream in the 4.6 bugfix branch [0]. Thanks for pointing > this out :) For the record: the position of the ignorelist-checks has been changed. Changing the default behavior and ignoring fstype "nfs" by default would be a backward incompatible change and thus would have to be scheduled for the next major version. However, I don't think we should do that. I'm pretty sure that there might be reasons to ignore other devices, file types, etc. as well by default, which might lead to inconsistent behavior (in the very likely case that not every situation is handled appropriately) and unexpected behavior. I think it's reasonable to expect that the local administrator handles such cases. However, feel free to convince me that I'm wrong ;-) Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
