Hi,

On Fri, Aug 21, 2009 at 03:51:55PM -0400, Joey Hess wrote:
> Severity: normal
> [...]
> - Accidentially still powered on laptop melts in its bag or causes
>   plane to crash into Hudson river. ;-)

... /* no comment */

> And that *is* a bug, I'm sure. dh.c runs this code much later than
> seems to be necessary:
> 
>                 if (ignorelist_match (il_fstype, mnt_ptr->type))
>                         continue;
>                 if (ignorelist_match (il_mountpoint, mnt_ptr->dir))
>                         continue;
> 
> I think that should definitly be moved to above the statfs call. And
> then I *suggest* the default config be changed to something like:
> 
> <Plugin df>
>         FSType "nfs"
>         IgnoreSelected true
> </Plugin>

Right. Fixed upstream in the 4.6 bugfix branch [0]. Thanks for pointing
this out :)

Regards,
-octo

[0] <http://git.verplant.org/?p=collectd.git;a=commitdiff;h=98ee1a63888>
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to