Hi Raphael, Am Samstag, den 13.06.2009, 22:08 +0200 schrieb Raphael Hertzog: > I agree on the principle but it seems difficult to do in practice. First > substvars can be used in dpkg-source, dpkg-gencontrol (usual case) and > dpkg-genchanges and they can possibly reuse the same substvars file (in > practice I suspect it almost never happens). > > It's probably only reasonable for dpkg-gencontrol and I have no idea > if it would create lots of false positives or not. > > Thus you can try to create a patch but it would be interesting to > do a full rebuild and check how many times it's triggered and > how many are false positives before we decide to include it. > (Maybe lucas can do this rebuild for you)
I gave it a shot, you can merge it from this git branch: http://git.debian.org/?p=users/nomeata/dpkg.git;a=shortlog;h=refs/heads/unused_substvars_532760 I rebuilt dpkg itself and a „most typical“ C/debhelper package (screen-message) with it, and it gave no (unexpected) warnings. Given that it does not break anything, maybe you can just include it in the next upload and see what happens? The first patch in my series is useful independently, as it adds a test script for Dpkg::Substvars, without any of the unused-vars-related changes. I guess you can pull that one in any case. Good night, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
