On Thu, 11 Jun 2009, Joachim Breitner wrote: > Therefore, dpkg-generated should warn about unused substvars. This could > be implemented in Dpkg::Substvars by remembering which vars have been > get()ted after being set()ted, and returning this list upon request. > > Please indicate if you agree and are willing to accept a patch.
I agree on the principle but it seems difficult to do in practice. First substvars can be used in dpkg-source, dpkg-gencontrol (usual case) and dpkg-genchanges and they can possibly reuse the same substvars file (in practice I suspect it almost never happens). It's probably only reasonable for dpkg-gencontrol and I have no idea if it would create lots of false positives or not. Thus you can try to create a patch but it would be interesting to do a full rebuild and check how many times it's triggered and how many are false positives before we decide to include it. (Maybe lucas can do this rebuild for you) Cheers, -- Raphaël Hertzog Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny : http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
