On Mon, Jun 27, 2005 at 12:35:19PM +0200, Stefano Zacchiroli wrote: > I left in place the DPGO_ORIGTARDIR as first attempt to find the > tarball, but of course it is now redundant. I suggest to mark it as > deprectated in the manpage (but I didn't do it by myself, it's up to > you).
Not quite. DPGO_ORIGTARDIR is the place where the caller (dpep in the first place, but svn-buildpackage can use dpgo as well) expects the orig.tar.gz to be for further processing. This is why dpgo checks whether the file is already there. You need to copy the file to the directory pointed to by DPGO_ORIGTARDIR since the caller expects the file to be exactly there and will yell at you if you don't put it there. > The only aspect I'm not happy with is that the patched script "manually" > sources /etc/dpatch.conf and ~/.dpatch.conf while some scripts of the > dpatch suite (not all, though) uses a SYSCONFDIR instead of hard coded > "/etc" which is filled at compiler time using awk. I doubt it will be > ever a problem thought. The idea of a search path is usually communicated via the Environment, so I'd prefer having dpgo look into the Environment and expect the caller to properly read the search path from its own configuration and set up the environment variable. I think this is the most general interface, keeping dpgo independent from dpatch configuration. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
