Package: wicd
Version: 1.5.9-4
Severity: normal
Tags: patch

Wicd doesn't go in misc.NOT_CONNECT status also if there isn't a 
wireless connection and if there isn't a wired connection.

The problem is in GetIP function in wnettools.py at line 525.

def GetIP(self):
        if not self.iface: return False

But method ConnectionStatus.check_for_wireless_connection in monitor.py
at line 97 checks for a None value. This condition is always False if 
wireless_ip is False and so check_for_wireless_connection returns always 
True.

A patch is attached.


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.7 (SMP w/1 CPU core; PREEMPT)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages wicd depends on:
ii  adduser                       3.110      add and remove users and groups
ii  dhcp3-client                  3.1.1-6    DHCP client
ii  iproute                       20090115-1 networking and traffic control too
ii  net-tools                     1.60-22    The NET-3 networking toolkit
ii  python                        2.5.4-2    An interactive high-level object-o
ii  python-dbus                   0.83.0-1   simple interprocess messaging syst
ii  python-glade2                 2.14.1-1   GTK+ bindings: Glade support
ii  python-gtk2                   2.14.1-1   Python bindings for the GTK+ widge
ii  python-support                0.8.7      automated rebuilding support for P
ii  wireless-tools                29-1.1     Tools for manipulating Linux Wirel
ii  wpasupplicant                 0.6.4-3    Client support for WPA and WPA2 (I

wicd recommends no packages.

Versions of packages wicd suggests:
ii  pm-utils                      1.2.4-2    utilities and scripts for power ma

-- no debconf information
=== modified file 'wicd/wnettools.py'
--- wicd/wnettools.py   2009-02-27 03:58:39 +0000
+++ wicd/wnettools.py   2009-03-12 11:38:45 +0000
@@ -522,7 +522,7 @@
         The IP address of the interface in dotted quad form.
 
         """
-        if not self.iface: return False
+        if not self.iface: return None
         cmd = 'ifconfig ' + self.iface
         if self.verbose: print cmd
         output = misc.Run(cmd)

Reply via email to