On Wed, 2009-01-21 at 20:19 +0100, Jan Engelhardt wrote:
> On Wednesday 2009-01-21 20:11, jamal wrote:
> >If you are on debian - you should be able to install iproute-dev package
> >and be fine I think. I just dload the tree.
>
> No, this is iproute2 which is missing some stuff.
> Specifically, doing this squashes away another compile error:
>
> diff --git a/tc/tc_util.h b/tc/tc_util.h
> index d84b09a..216d6cd 100644
> --- a/tc/tc_util.h
> +++ b/tc/tc_util.h
> @@ -2,9 +2,11 @@
> #define _TC_UTIL_H_ 1
>
> #define MAX_MSG 16384
> +#include <linux/types.h>
> #include <linux/pkt_sched.h>
> #include <linux/pkt_cls.h>
> #include <linux/gen_stats.h>
> +#include <linux/rtnetlink.h>
> #include "tc_core.h"
>
> /* This is the deprecated multiqueue interface */
>
Our environments are probably different - reason why i am not seeing
what you are seeing. For sure, the iproute2 build system could use
a lot of improvement, so i dont doubt you that the above is needed.
> >In any case, I am afraid that still doesnt fix the backward/forward
> >compat challenge.
>
> First things first. If you can get it to run with current libxtables.so,
> perhaps with some more changes as needed, you can call that an
> achievement and later fix the old m_ipt.
>
The patch i posted compiles and has been tested. It also attempts
to address the backward and forward compat.
Like i said earlier - i seem to have miscommunicated. This is not
the problem i was trying to address with the patch i sent for the
header changes; rather the issue i was trying to address is one
i anticipate in the future i.e the discussion on the compile below
highlights it.
> You tried a link. I only compiled it (partially, due to the errors).
> However, program_version, afinfo and program_name are supposed to
> be provided by the program itself (iptables, ip6tables, not libxtables)
> in this case m_ipt.c.
Sure, and the tc/ipt patch i posted does that + a little more - I just
wanted to demonstrate a simple case.
The following compiles cleanly with the same compile options.
----
#include <xtables.h>
#include <xtables/internal.h>
#include <stdlib.h>
char *lib_dir;
unsigned int global_option_offset = 0;
const char *program_version = "1.4.2";
const char *program_name = "tc-ipt";
struct afinfo afinfo = {
.libprefix = "libxt_",
};
void exit_error(enum exittype status, const char *msg, ...)
{
exit(status);
}
int main(int argc, char **argv) {
return 0;
}
---------
With tc/ipt referencing other APIs within libxtables, the compile errors
include everything i have tagged with TC_CONFIG_XIPT_H
cheers,
jamal
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
