On Saturday 2009-01-17 17:24, jamal wrote:
>On Sat, 2009-01-17 at 17:15 +0100, Jan Engelhardt wrote:
>
>> internal files really should not be used - they are called internal
>> for a reason, and you can't really miss that with a name
>> like "internal.h", can you? :D
>> 
>> Everything that libxtables.so provides is in xtables.h. Or should be, in 
>> case something is missing.
>
>xtables.h does refer to it.
>------
>#ifdef XTABLES_INTERNAL
>#       include <xtables/internal.h>
>#endif
>----

But only when XTABLES_INTERNAL is defined, which only ought to be
true for iptables itself, and not iproute.

>And ipt makes references to somethings on it, find_target(), fw_calloc()
>etc.
>I could of course move it to be part of iproute2 but that does sound
>unclean (compared to being in /usr/include). Note: so far in order
>to keep up, iproute2 has always copied all includes needed. I would
>like to avoid that if possible.

Then, as just mentioned, move the declaration of find_target to
xtables.h (and the code to xtables.c too, so that it ends up in
libxtables.so, if it is not already).



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to