Hi Hampa!

You wrote:

> > However, in the actual code, these 3 bytes are skipped not only for AC3
> > streams (stream id 0xbd, substream 0x80-x09f), but for _any_ private
> > substream (including, for example, vobsub subtitle streams).  
> 
> This is actually the intended behaviour. Mpegdemux does not make assumptions
> about the content of elementary streams (I have encountered program
> streams that contained AC3 sound in private streams other than 0x80-0x9f).
> Note that the --spu option (for extracting subtitles) has the same
> behaviour (if the option is used, all selected private streams are assumed
> to contain subtitles). I agree that the man page is at best ambiguous
> about this. I think the best solution is to fix the man page.

Ah ok, that makes sense.  It would be great if you could clarify that in
the man page.

> > Here's an updated patch to fix this.  I kept the check for the integer
> > overflow in, as it might expose othe rbug in the code.
> 
> What other bugs? There are no other bugs! ;-)

Hehe.
Thanks for you efforts with this program btw.  It's the most decent mpeg
demuxer I've used so far.  Keep on the good work!

Greetings,
Bas.

-- 
+--------------------------------------------------------------+
| Bas Zoetekouw      | Sweet day, so cool, so calm, so bright, |
|--------------------| The bridall of the earth and skie:      |
| b...@zoetekouw.net  | The dew shall weep thy fall tonight;    |
+--------------------|                    For thou must die.   |
                     +-----------------------------------------+



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to