Bas, Santiago, Bas Zoetekouw wrote:
> Upon further debugging, I managed to find the real cause of the problem > (I think). The issue is cause by the --ac3 option, which according to > the man page does the following: > > | AC3 sound packets in DVD MPEG2 streams have a 3 byte header that is > | neither part of the MPEG specification nor of the AC3 specification. > | When this option is used, these 3 bytes are removed to produce a > | correct AC3 stream. > > However, in the actual code, these 3 bytes are skipped not only for AC3 > streams (stream id 0xbd, substream 0x80-x09f), but for _any_ private > substream (including, for example, vobsub subtitle streams). This is actually the intended behaviour. Mpegdemux does not make assumptions about the content of elementary streams (I have encountered program streams that contained AC3 sound in private streams other than 0x80-0x9f). Note that the --spu option (for extracting subtitles) has the same behaviour (if the option is used, all selected private streams are assumed to contain subtitles). I agree that the man page is at best ambiguous about this. I think the best solution is to fix the man page. Not checking the packet length is a genuine bug. > Here's an updated patch to fix this. I kept the check for the integer > overflow in, as it might expose othe rbug in the code. What other bugs? There are no other bugs! ;-) cheers, Hampa -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
