On Mon, 03 Mar 2008, Colin Watson wrote:
> Yes, I know - I meant conceptually rather than in detail. notfixed
> should not leave the bug in a fixed/done-type state.

The problem is that giving it side effects (reopening the bug) means
that it's no longer associative.

That is, 

fixed NNN VER1
notfixed NNN VER

would be (potentially) very different from

notfixed NNN VER
fixed NNN VER1

however,

found NNN VER1
notfound NNN VER

would still be the same as

notfound NNN VER
found NNN VER1

That seems to violate (at least for me) the principle of least
surprise. Perhaps the right way is to make the documentation for
notfixed slightly more clear than it already is and explain that you
normally actually want found, not notfixed. [It is already the last of
the version-modifying methods mentioned because it's only useful in
specific cases.[1]]

Any time that it was improperly marked as fixed in a normal
situtation, you'd want to use "found", because you know that the
version you've just tested is buggy.

> As it happens, I added notfound and you added fixed/notfixed. ;-)

Heh. I've touched that code so much now that it just seems like I
wrote it originally. ;-)


Don Armstrong

1: The main reason why I need a command like it is that it makes it
really easy to fix source/version problems where the source package is
wrong. I just notfixed version fixed version; without worying about
whether it's going to screw with the -done-ness of the bug.
-- 
The state must declare the child to be the most precious treasure of
the people. As long as the government is perceived as working for the
benefit of the children, the people will happily endure almost any
curtailment of liberty and almost any deprivation.
 -- Adolf Hitler _Mein Kampf_ p403

http://www.donarmstrong.com              http://rzlab.ucr.edu



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to