On Mon, Mar 03, 2008 at 01:52:59AM +0100, Emilio Pozuelo Monfort wrote: > > The patch _was_ applied, but then reverted again by doko's latest > > changes before upload. His commit message makes note of fixing warnings > > so I'm not sure if this was deliberate or accidental ... Are you certain > > this isn't really a bug in amule and the suggested patch is not wrong? > > Those warnings are in different files (char * -> const char *).
Those were in a different patch/commit. The commit/changelog message I'm referring to says: "- Fix for GTK warnings in wxNotebook::DoRemovePage." With enough hindsight to light the way though, I can now see that this is just verbatim from the upstream commit. Apparently in the wxLexicon, an assertion failure and crash simply constitute 'warnings'... doko was also able to confirm he believes this was an accident. It looks like he's tried to reapply this fix to source that already had it, and either patch has automatically reversed it, or he resolved the conflict backwards. > The patch patch is from upstream, which was first committed to HEAD and then > backported to the 2.6 branch, and it hasn't been reverted or something, as you > can see at http://cvs.wxwidgets.org/viewcvs.cgi/wxWidgets/src/gtk/notebook.cpp > > Also, the patch has been in Ubuntu for some time and I haven't heard of any > complain about it. It fixed a bug where aMule was crashing when closing search > tabs, and was backported to an stable (Edgy) release. Yes, I recall being reasonably comfortable with it when I first applied it, I was just getting a lot of mixed messages which was raising red flags I needed some answers for. I think I can see what's happened now though, so I'll reapply that change to the repo again. Cheers, Ron -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
