Bug#466515: PTS: "you should include ."

[Thijs Kinkhorst]

On Tuesday 19 February 2008 11:55, Lars Wirzenius wrote:
> On ti, 2008-02-19 at 11:23 +0100, Holger Levsen wrote:
> > And as this isn't always right, I suggest to use a less strong wording.
> > "You should look at.." or "You could include". Or whatever. But _all_
> > those patches should definitly _not_ be included.
>
> I concur, although I suggest that the wording could say that if the
> patch is inappropriate, the patch tag should be removed.

I've changed the patch to replace "you should include it/them" with "consider 
including it/them".

Regarding Lars' remark: the ways to express that I can think of make the text 
considerably longer and hence IMHO out of place in the PTS, which should be a 
concise overview of a package, not a detailed instruction of what to do. :-)


Thijs

Index: pts.xsl
===================================================================
--- pts.xsl	(revision 1830)
+++ pts.xsl	(working copy)
@@ -848,8 +848,9 @@
 	<li>The Bug Tracking System contains
           <a href="http://bugs.debian.org/cgi-bin/pkgreport.cgi?which=src&amp;data={$escaped-package}&amp;include=tags:patch&amp;exclude=tags:pending&amp;pend-exc=done";>patches fixing
 	    <xsl:value-of select="$other/bugs/@patch"/> bug<xsl:if test="$other/bugs/@patch!='1'">s</xsl:if>
-          </a>, you should include
-	  <xsl:if test="$other/bugs/@patch!='1'">them</xsl:if>.
+          </a>, consider including
+	  <xsl:if test="$other/bugs/@patch!='1'">them</xsl:if>
+	  <xsl:if test="$other/bugs/@patch='1'">it</xsl:if>.
 	</li>
       </xsl:if>
     </xsl:if>

pgpOBYmUywtZP.pgp
Description: PGP signature