Package: icu
Version: 3.6-7
Severity: normal

I wanted to apply a local patch to icu and put it into debian/patches.
But then I had to see that it is only partly applied (see any buildd log for verify):

- first the source in extracted into
  build-tree/icu/source
- then debian/rules target pre-build:: is executed
  which copies over (look for "cp -a" in the logs) everything to
  build-tree/icu/source-build
- then the patches are applied
- and finally for a second build the now patched
  build-tree/icu/source is copied over to build-tree/icu/source-build
  again.

So the first build is done without the patches, the second with the patches applied. If that is intentional, it should be expressed more clearly.

I also see that icu-3.8 doesn't need any patches for the official package, but nevertheless this should be changed there, too, as cdbs's simple-patchsys.mk is still included and one might (re-)start using it (re-)introducing this ugliness again.

Another ugliness is that ./configure is run in build-tree/icu/source, but later in build-tree/icu/source-build again, and for the second build it's run the third time, again in build-tree/icu/source-build. So probably it's unnecessary to run it in build-tree/icu/source.

For the 32/64 archs it's even worse: ./configure is run twice in a row for build-tree/icu/source-build{,32}, resulting in 8 runs entirely, see: http://experimental.debian.net/fetch.php?&pkg=icu&ver=3.8-1&arch=amd64&stamp=1193018951&file=log&as=raw

Martin



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to